OC-31 support compilestatic#267
Merged
Merged
Conversation
…rator to separate class, corrected inclusion pattern in surefire, added more tests to TestSuite
…xprEval and addEvalElvis to use generic signature instead of def (draft version)
Open
…is and instruction selection; Grover renamed to CloverAstTransformerInstructionSelection, parts of it extracted to CloverAstTransformerSemanticAnalysis and CloverAstTransformerBase; adding elvisEval and exprEval in the semantic analysis phase as we want Groovy to resolve the <T> type parameter
…instruction selection; in the semantic analysis add multiple overloaded elvisEval methods - one for every primitive type and one for 'def'; added dedicated GroovyElvisOperatorTest which runs with and without CompileStatic annotation
…as all tests pass), removed generic version of addExprEval and restored def version of addExprEvalDef (we don't need generics exprEval because InstrumentingCodeVisitor adds type cast, if needed)
…lassNodeXyzTransformers, shortened CloverAstTransformerBase code by moving static classes to top level
…ssion returns null; added opentest4j-1.2.0.jar to test classpath as it's required by Spock; rewritten use of Matchers in SpockCombinatorMixin as it couldn't find a match
… 4-arg constructor)
…." was incorrectly matched as a test case; corrected withJUnit5 condition as spockVersion contains full string (like 'spock-core-2.3-groovy-4.0') and not just a version number; thanks to this Spock 2.x runs with JUnit5 now
…lready a part of TestSuite, correct inline comments, add empty lines at end of file
…e fields don't exist), removed 'spock-core-' prefix from Spock version (now it's 'X.Y-groovy-X.Y'), added Spock 2.4 and Groovy 5.0 to the SpockVersions list
…ce character as part of the elvis operator character range; added explicit test for EmptyExpression instance (problem reported for Groovy 3.0; it was already fixed in another ticket)
…arSequence)", extracted StatementsTrait to a separate test and disabled it (as CLOV-1960 is not implemented)
…in classes which have used such expression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.