Add MACsec SAI API, version 1.0

[DeanKalla]

First Draft of MACsec SAI API Proposal Document.

[kcudnik]

please fix all the errors and warnings https://sonic-jenkins.westus2.cloudapp.azure.com/job/sai-meta-pr-build/1812/console

[DeanKalla]

Warnings have been resolved but there is one issue with the build I am not sure how to resolve. I'm new to this codebase and build, could someone help me understand what this metadata build error means?

ERROR: FATAL ERROR === MUST FIX === : Could not open file 'xml/xml/union__sai__macsec__auth__key__t.xml' No such file or directory at xmlutils.pm line 163.

[kcudnik]

• change SAI_MACSEC_SA_ATTR_DIRECTION to SAI_MACSEC_SA_ATTR_MASCEC_DIRECTION on condition
• also conditions on stat enums are not supported
• SAI_OBJECT_TYPE_MAX must have consecutive number after SAI_OBJECT_TYPE_MACSEC_SA
• fix spelling
• add SAI_API_MACSEC entry in sai_api_t
• you introduced 4 new types, you will have to add 4 serialize and 4 deserialize methods (look at meta/saiseralise.[ch] and at compiler errors
• change SAI_ATTR_VALUE_TYPE_ACL_FIELD_DATA_SCI to SAI_ATTR_VALUE_TYPE_ACL_FIELD_DATA_MACSEC_SCI

i added some enhancements to parser to minimize your impact #1015

please marge and retest and fix errors

[kcudnik]

retest this please

[prafull-brcm]

In sai.h header file one change is required to add MACsec APIs.

SAI_API_MACSEC           = 43, /**< sai_macsec_api_t */
SAI_API_MAX              = 44, /**< total number of APIs */

} sai_api_t;

[tfangit]

Looks good to me. Thx for the work.

[DeanKalla]

Can we merge this PR as-is? We can make more PR for other enhancements.

[SidharajU]

Need to revisit if there is a requirement to support upfront SA creation.