Skip to content

Conversation

@gh4683
Copy link
Contributor

@gh4683 gh4683 commented Jul 7, 2025

  • Added all send and receive streaming messages for RotateAIKCert()
  • Added more stubs for functions needed to implement this logic
  • Added TPMIdentityRequest Structure (and dependent structures) to parse the application_identity_request bytes
  • Added a basic test for RotateAIKCert()

@coveralls
Copy link

coveralls commented Jul 7, 2025

Pull Request Test Coverage Report for Build 16208374783

Details

  • 130 of 209 (62.2%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.1%) to 45.11%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/biz/enrollz_biz.go 90 169 53.25%
Totals Coverage Status
Change from base Build 16207458523: 3.1%
Covered Lines: 881
Relevant Lines: 1953

💛 - Coveralls

@gh4683 gh4683 marked this pull request as ready for review July 7, 2025 19:15
@gh4683 gh4683 requested a review from a team as a code owner July 7, 2025 19:15
Copy link

@wlanmac wlanmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to also perhaps stub out a test for the new code.

@gh4683 gh4683 force-pushed the aik-2 branch 3 times, most recently from 434e2ad to 86f2cbe Compare July 8, 2025 21:10
@gh4683 gh4683 requested review from betuls and wlanmac and removed request for wlanmac July 8, 2025 21:11
Copy link
Contributor

@betuls betuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is structured well, please rename biz_utils to a more specific one such as tpm12_utils or tpm12_structures or tpm12_parcers

@gh4683 gh4683 force-pushed the aik-2 branch 4 times, most recently from 40b66af to cb28c23 Compare July 10, 2025 22:00
@gh4683 gh4683 requested review from betuls and wlanmac July 10, 2025 22:01
@betuls betuls merged commit 275ff17 into openconfig:main Jul 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants