Skip to content

Log public key algorithm for TLS certificates#306

Open
gmacf wants to merge 2 commits intomainfrom
gmacf-patch-11
Open

Log public key algorithm for TLS certificates#306
gmacf wants to merge 2 commits intomainfrom
gmacf-patch-11

Conversation

@gmacf
Copy link
Copy Markdown
Contributor

@gmacf gmacf commented Apr 22, 2026

No description provided.

@gmacf gmacf requested a review from Chounoki April 22, 2026 02:17
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the LogPeerTLSCertificate function in common/tls/tls.go to include the public key algorithm in the log output. Feedback was provided to remove redundant .String() calls and mitigate a potential nil pointer panic when logging the certificate's serial number.

Comment thread common/tls/tls.go Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants