Skip to content

add core validator to feature profiles#2296

Merged
marcushines merged 2 commits into
openconfig:mainfrom
h-fam:main
Oct 27, 2023
Merged

add core validator to feature profiles#2296
marcushines merged 2 commits into
openconfig:mainfrom
h-fam:main

Conversation

@marcushines
Copy link
Copy Markdown
Contributor

No description provided.

@marcushines marcushines requested a review from a team as a code owner October 25, 2023 20:25
@marcushines marcushines requested a review from a team October 25, 2023 20:25
@OpenConfigBot
Copy link
Copy Markdown

OpenConfigBot commented Oct 25, 2023

Pull Request Functional Test Report for #2296 / 96c9f16

No tests identified for validation.

Help

@greg-dennis greg-dennis self-assigned this Oct 25, 2023
@marcushines marcushines force-pushed the main branch 4 times, most recently from 7f95f0a to 3ef4ab2 Compare October 26, 2023 16:37
Comment thread internal/core/core.go
Comment thread internal/core/core.go Outdated
Comment thread internal/core/core.go Outdated
Comment thread internal/core/core.go Outdated
Comment thread internal/core/core.go Outdated
Comment thread internal/core/core.go Outdated
Comment thread internal/core/core.go Outdated
Comment thread internal/core/core.go Outdated
Comment thread internal/core/core_test.go
Comment thread internal/core/core.go
Comment thread internal/core/core.go Outdated
Comment thread internal/core/core.go Outdated
Comment thread internal/core/core.go
Copy link
Copy Markdown
Contributor

@greg-dennis greg-dennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thought below that you could take or leave ...

Comment thread internal/core/core.go Outdated
Comment thread internal/core/core.go Outdated
Comment thread internal/core/core.go Outdated
Comment thread internal/core/core.go
Comment thread internal/core/core.go
Comment thread internal/core/core.go
Comment thread internal/core/core.go
Comment thread internal/core/core.go Outdated
Comment thread internal/core/core.go
Comment thread internal/core/core.go
thesrinath
thesrinath previously approved these changes Oct 27, 2023
Comment thread go.mod Outdated
Comment thread internal/core/core.go Outdated
@marcushines marcushines added enhancement New feature or request google-pr labels Oct 27, 2023
@marcushines marcushines merged commit f36af19 into openconfig:main Oct 27, 2023
frasieroh pushed a commit to aristanetworks/openconfig-featureprofiles that referenced this pull request Oct 27, 2023
frasieroh pushed a commit to aristanetworks/openconfig-featureprofiles that referenced this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request google-pr

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants