Skip to content

Include HW name in nosimage.proto#2947

Merged
wenovus merged 4 commits intomainfrom
nosimage-include-hw
Jul 9, 2024
Merged

Include HW name in nosimage.proto#2947
wenovus merged 4 commits intomainfrom
nosimage-include-hw

Conversation

@wenovus
Copy link
Contributor

@wenovus wenovus commented May 2, 2024

No description provided.

@wenovus wenovus requested a review from dplore May 2, 2024 02:26
@wenovus wenovus requested a review from a team as a code owner May 2, 2024 02:26
@wenovus wenovus requested a review from a team May 2, 2024 02:26
@OpenConfigBot
Copy link

OpenConfigBot commented May 2, 2024

Pull Request Functional Test Report for #2947 / e21be57

No tests identified for validation.

Help

@coveralls
Copy link

coveralls commented May 2, 2024

Pull Request Test Coverage Report for Build 9522863784

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.5%

Totals Coverage Status
Change from base Build 9518324209: 0.0%
Covered Lines: 1983
Relevant Lines: 3573

💛 - Coveralls

@wenovus
Copy link
Contributor Author

wenovus commented May 2, 2024

@earies for comments

@dplore
Copy link
Member

dplore commented Jul 9, 2024

This looks good enough to me. I'm not seeing a better idea at the moment to record hardware

@wenovus wenovus merged commit 03cfee5 into main Jul 9, 2024
@wenovus wenovus deleted the nosimage-include-hw branch July 9, 2024 23:09
sunilprgit pushed a commit to sunilprgit/featureprofiles that referenced this pull request Jul 10, 2024
* Include HW name in nosimage.proto

* Fix

* don't break proto
frasieroh pushed a commit to aristanetworks/openconfig-featureprofiles that referenced this pull request Jul 10, 2024
* Include HW name in nosimage.proto

* Fix

* don't break proto
rohit-rp pushed a commit that referenced this pull request Jul 11, 2024
* fix link_bandwidth_test

* Include HW name in nosimage.proto (#2947)

* Include HW name in nosimage.proto

* Fix

* don't break proto

* fix static analysis

* Create a Readme file for DP-1.5 (#3044)

* reate a Readme file for DP-1.5 Egress Strict Priority scheduler with bursty traffic

* Update DP-1.5 Readme

* fix for deviation and adding AS check for dut AS

---------

Co-authored-by: Wen Bo Li <50884368+wenovus@users.noreply.github.com>
Co-authored-by: ihebboubaker <126072465+ihebboubaker@users.noreply.github.com>
frasieroh pushed a commit to aristanetworks/openconfig-featureprofiles that referenced this pull request Jul 12, 2024
* fix link_bandwidth_test

* Include HW name in nosimage.proto (openconfig#2947)

* Include HW name in nosimage.proto

* Fix

* don't break proto

* fix static analysis

* Create a Readme file for DP-1.5 (openconfig#3044)

* reate a Readme file for DP-1.5 Egress Strict Priority scheduler with bursty traffic

* Update DP-1.5 Readme

* fix for deviation and adding AS check for dut AS

---------

Co-authored-by: Wen Bo Li <50884368+wenovus@users.noreply.github.com>
Co-authored-by: ihebboubaker <126072465+ihebboubaker@users.noreply.github.com>
bkreddy143 pushed a commit to nokia/featureprofiles that referenced this pull request Jul 17, 2024
* Include HW name in nosimage.proto

* Fix

* don't break proto
bkreddy143 pushed a commit to nokia/featureprofiles that referenced this pull request Jul 17, 2024
* fix link_bandwidth_test

* Include HW name in nosimage.proto (openconfig#2947)

* Include HW name in nosimage.proto

* Fix

* don't break proto

* fix static analysis

* Create a Readme file for DP-1.5 (openconfig#3044)

* reate a Readme file for DP-1.5 Egress Strict Priority scheduler with bursty traffic

* Update DP-1.5 Readme

* fix for deviation and adding AS check for dut AS

---------

Co-authored-by: Wen Bo Li <50884368+wenovus@users.noreply.github.com>
Co-authored-by: ihebboubaker <126072465+ihebboubaker@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants