Add the initial ISIS base and adjacency feature profile by drautio · Pull Request #3 · openconfig/featureprofiles

drautio · 2021-12-20T21:37:19Z

Add the initial ISIS base and adjacency feature profile.

On branch isis-1 Changes to be committed: new file: isis/base_isis_and_adjacenty/feature.textproto Add the initial ISIS base and adjacency feature profile.

isis/base_isis_and_adjacenty/feature.textproto

dplore · 2022-01-11T03:37:28Z

@drautio friendly reminder, can you respond to the comments?

On branch isis-1 Your branch is up to date with 'origin/isis-1'. Changes to be committed: new file: isis/isis_auth/feature.textproto renamed: isis/base_isis_and_adjacenty/feature.textproto -> isis/isis_base/feature.textproto address comments

drautio · 2022-01-24T21:24:03Z

I addressed all the comments and uploaded new files.

sthesayi

Just a couple of minor comments. LGTM.

sthesayi · 2022-01-24T23:05:15Z

isis/isis_auth/feature.textproto

+}
+telemetry_path {
+  path: "/network-instances/network-instance/protocols/protocol/isis/interfaces/interface/authentication/key/state/auth-password"
+}


We should have a dependency on isis_base feature profile.

isis/isis_auth/feature.textproto

… to check for DUT vendor at the start of the test with the help of a map and moved PID finding logic into its own function

* Code commit for TE-8.1: DUT Daemon Failure * Updated file permissions and made some minor changes in the code comments * Updated file permissions again * Removed newline in the end * Addressed review comments: updated Arista and Cisco gRIBI daemon names, changed gNOI kill signal from sigkill to sigterm and changed traffic flow setup as suggested. * Addressed review comments #2: removed testTraffic and reused startTraffic/stopAndVerifyTraffic instead * Addressed review comments #3: Gribi -> GRIBI, added support to check for DUT vendor at the start of the test with the help of a map and moved PID finding logic into its own function

* Code commit for TE-8.1: DUT Daemon Failure * Updated file permissions and made some minor changes in the code comments * Updated file permissions again * Removed newline in the end * Addressed review comments: updated Arista and Cisco gRIBI daemon names, changed gNOI kill signal from sigkill to sigterm and changed traffic flow setup as suggested. * Addressed review comments openconfig#2: removed testTraffic and reused startTraffic/stopAndVerifyTraffic instead * Addressed review comments openconfig#3: Gribi -> GRIBI, added support to check for DUT vendor at the start of the test with the help of a map and moved PID finding logic into its own function

* Code commit for TE-8.1: DUT Daemon Failure * Updated file permissions and made some minor changes in the code comments * Updated file permissions again * Removed newline in the end * Addressed review comments: updated Arista and Cisco gRIBI daemon names, changed gNOI kill signal from sigkill to sigterm and changed traffic flow setup as suggested. * Addressed review comments #2: removed testTraffic and reused startTraffic/stopAndVerifyTraffic instead * Addressed review comments #3: Gribi -> GRIBI, added support to check for DUT vendor at the start of the test with the help of a map and moved PID finding logic into its own function

…up (openconfig#3552)

Update the PR to replace v4 transport with v6 transport. Following changes: 1. **All IP addresses for the test:** * Replaced with following IPv6 equivalents for the tunnel endpoint IP variables: * `$DUT_TE11.v6/128` * `$DUT_TE10.v6/128` * `$ATE2_INTERNAL_TE11.v6/128` * `$ATE2_INTERNAL_TE10.v6/128` 2. **Advertisements - BGP:** * Updated `$ATE2_IBGP.v[46]<>$DUT_lo0.v[46]` peering to advertise/expect `/128`, `/64' for the TE IPs. - $ATE2_INTERNAL_TE10.v4/30 --replaced by--> $ATE2_INTERNAL_TE10.v6/64 - `$ATE2_INTERNAL_TE11.v4/30 -- replaced by --> `$ATE2_INTERNAL_TE11.v6/64 - $DUT_TE10.v4/30 -- replaced by --> $DUT_TE10.v6/64 - $DUT_TE11.v4/30 -- replaced by --> $DUT_TE11.v6/64 * Updated `$ATE2_Port3<>$DUT_Port4` peering to advertise/expect `/128`, `/64` for the TE IPs. 3. **Different Flows used throughout the test:** * The "Tunnel endpoint used" column for Flow-Sets #1, #2, #3, and #4 now references the `.v6/128` tunnel IP variables (e.g., `$ATE2_INTERNAL_TE11.v6/128`, `$DUT_TE11.v6/128`). - ATE2_INTERNAL_TE11.v4/32 --replaced by--> ATE2_INTERNAL_TE11.v6/128 - $DUT_TE11.v4/30 --replaced to--> $DUT_TE11.v6/64 4. **DUT Configuration:** * Under **Static GUE Encapsulation (IPv6 Transport):** * `tunnel-source` changed from `$DUT_lo0.v4` to `$DUT_lo0.v6`. * `tunnel-destination1` changed to `$ATE2_INTERNAL_TE11.v6/128`. * `tunnel-destination2` changed to `$ATE2_INTERNAL_TE10.v6/128`. * Static route next-hops changed to the `.v6/128` tunnel destinations. * Under **GUE Decapsulation:** * Decapsulation ranges changed from `$DUT_TE11.v4/30` and `$DUT_TE10.v4/30` to `$DUT_TE11.v6/127` and `$DUT_TE10.v6/127`. 5. **Test Expectations:** * In RT-3.52.2, RT-3.52.5, RT-3.52.6, RT-3.52.7, and RT-3.52.8, expected tunnel destination IPs in the flow descriptions are changed to the `.v6/128` variables. 6. **Canonical OC - For GUEv1 Encapsulation configuration (IPv6 Transport) updated aswell. Following changes:** * Changed `type` from `UDPV4` to `UDPV6`. * Changed `udp-v4` block to `udp-v6`. * Updated `dst-ip` to `$ATE2_INTERNAL_TE11.v6`. * Updated `src-ip` to `$DUT_lo0.v6`.

* Update README.md Update the PR to replace v4 transport with v6 transport. Following changes: 1. **All IP addresses for the test:** * Replaced with following IPv6 equivalents for the tunnel endpoint IP variables: * `$DUT_TE11.v6/128` * `$DUT_TE10.v6/128` * `$ATE2_INTERNAL_TE11.v6/128` * `$ATE2_INTERNAL_TE10.v6/128` 2. **Advertisements - BGP:** * Updated `$ATE2_IBGP.v[46]<>$DUT_lo0.v[46]` peering to advertise/expect `/128`, `/64' for the TE IPs. - $ATE2_INTERNAL_TE10.v4/30 --replaced by--> $ATE2_INTERNAL_TE10.v6/64 - `$ATE2_INTERNAL_TE11.v4/30 -- replaced by --> `$ATE2_INTERNAL_TE11.v6/64 - $DUT_TE10.v4/30 -- replaced by --> $DUT_TE10.v6/64 - $DUT_TE11.v4/30 -- replaced by --> $DUT_TE11.v6/64 * Updated `$ATE2_Port3<>$DUT_Port4` peering to advertise/expect `/128`, `/64` for the TE IPs. 3. **Different Flows used throughout the test:** * The "Tunnel endpoint used" column for Flow-Sets #1, #2, #3, and #4 now references the `.v6/128` tunnel IP variables (e.g., `$ATE2_INTERNAL_TE11.v6/128`, `$DUT_TE11.v6/128`). - ATE2_INTERNAL_TE11.v4/32 --replaced by--> ATE2_INTERNAL_TE11.v6/128 - $DUT_TE11.v4/30 --replaced to--> $DUT_TE11.v6/64 4. **DUT Configuration:** * Under **Static GUE Encapsulation (IPv6 Transport):** * `tunnel-source` changed from `$DUT_lo0.v4` to `$DUT_lo0.v6`. * `tunnel-destination1` changed to `$ATE2_INTERNAL_TE11.v6/128`. * `tunnel-destination2` changed to `$ATE2_INTERNAL_TE10.v6/128`. * Static route next-hops changed to the `.v6/128` tunnel destinations. * Under **GUE Decapsulation:** * Decapsulation ranges changed from `$DUT_TE11.v4/30` and `$DUT_TE10.v4/30` to `$DUT_TE11.v6/127` and `$DUT_TE10.v6/127`. 5. **Test Expectations:** * In RT-3.52.2, RT-3.52.5, RT-3.52.6, RT-3.52.7, and RT-3.52.8, expected tunnel destination IPs in the flow descriptions are changed to the `.v6/128` variables. 6. **Canonical OC - For GUEv1 Encapsulation configuration (IPv6 Transport) updated aswell. Following changes:** * Changed `type` from `UDPV4` to `UDPV6`. * Changed `udp-v4` block to `udp-v6`. * Updated `dst-ip` to `$ATE2_INTERNAL_TE11.v6`. * Updated `src-ip` to `$DUT_lo0.v6`. * Update README.md Update some of the AI suggested changes around duplicate IP addresses. * Update feature/policy_forwarding/encapsulation/otg_tests/staticgueencap_and_bgp_path_selection/README.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update feature/policy_forwarding/encapsulation/otg_tests/staticgueencap_and_bgp_path_selection/README.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update feature/policy_forwarding/encapsulation/otg_tests/staticgueencap_and_bgp_path_selection/README.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update README.md Correcting all occurrences of encaped to encapsulated. * Update README.md Updated incorrect OC Paths * Update README.md Updating the canonical OC to use UDP-V4 encap headers temporarily as a placeholder. * Update README.md Fixing the error message "parent container ipv6-prefix-set ... JSON contains unexpected field prefix" which is caused by the prefix leaf-list being placed at the wrong level in the JSON structure. --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Darren Loher <dloher@google.com>

Committer: Dan Rautio <drautio@google.com>

46d0ca7

On branch isis-1 Changes to be committed: new file: isis/base_isis_and_adjacenty/feature.textproto Add the initial ISIS base and adjacency feature profile.

drautio requested a review from rsgcp December 20, 2021 21:37

dplore changed the title ~~Committer: Dan Rautio <drautio@google.com>~~ Add the initial ISIS base and adjacency feature profile Dec 20, 2021

sthesayi reviewed Dec 22, 2021

View reviewed changes

sthesayi requested a review from dplore December 22, 2021 14:24

Committer: Dan Rautio <drautio@google.com>

638641c

On branch isis-1 Your branch is up to date with 'origin/isis-1'. Changes to be committed: new file: isis/isis_auth/feature.textproto renamed: isis/base_isis_and_adjacenty/feature.textproto -> isis/isis_base/feature.textproto address comments

sthesayi approved these changes Jan 24, 2022

View reviewed changes

drautio merged commit 2f17fb2 into main Jan 25, 2022

dplore mentioned this pull request Feb 9, 2022

Add the ISIS feature profile #1

Closed

dplore deleted the isis-1 branch February 17, 2022 16:28

LimeHat mentioned this pull request Mar 17, 2023

rt-3.2: update case#3 to skip the test if PF config is rejected #1301

Merged

rszarecki mentioned this pull request Sep 7, 2023

DP-1.3 TestPlan: QoS ECN feature config - parameter adjustment #2101

Closed

nsadhasivam added a commit to nsadhasivam/featureprofiles that referenced this pull request Oct 30, 2024

b/374639328 openconfig#3 30 sec delay added for bgp and isis to come up

7b604c5

nsadhasivam added a commit that referenced this pull request Oct 30, 2024

b/374639328 #3 30 sec delay added for bgp and isis to come up (#3552)

d4c51f0

alshabib pushed a commit to alshabib/featureprofiles that referenced this pull request Jan 19, 2025

b/374639328 openconfig#3 30 sec delay added for bgp and isis to come …

5a4d244

…up (openconfig#3552)

sachendras mentioned this pull request Nov 12, 2025

Adding RT-3.52: Multidimensional test for Static GUE Encap/Decap based on BGP path selection and selective DSCP marking #4519

Open

nupkanoi mentioned this pull request Mar 17, 2026

Add README for Double GUE Decapsulation #5081

Closed

This was referenced Mar 26, 2026

RT-5.7 Fix #5263

Closed

RT-5.7_Fix #5264

Open

gemini-code-assist bot mentioned this pull request Mar 26, 2026

feat: Double GUE Decapsulation (PF-1.26) #5266

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add the initial ISIS base and adjacency feature profile#3

Add the initial ISIS base and adjacency feature profile#3
drautio merged 2 commits intomainfrom
isis-1

drautio commented Dec 20, 2021 •

edited by dplore

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dplore commented Jan 11, 2022

Uh oh!

drautio commented Jan 24, 2022

Uh oh!

sthesayi left a comment

Uh oh!

sthesayi Jan 24, 2022

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

drautio commented Dec 20, 2021 • edited by dplore Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dplore commented Jan 11, 2022

Uh oh!

drautio commented Jan 24, 2022

Uh oh!

sthesayi left a comment

Choose a reason for hiding this comment

Uh oh!

sthesayi Jan 24, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

drautio commented Dec 20, 2021 •

edited by dplore

Loading