Modifications to RT 1.28-BGP to IS-IS redistribution#3359
Merged
ram-mac merged 6 commits intoopenconfig:mainfrom Nov 29, 2024
Merged
Modifications to RT 1.28-BGP to IS-IS redistribution#3359ram-mac merged 6 commits intoopenconfig:mainfrom
ram-mac merged 6 commits intoopenconfig:mainfrom
Conversation
Pull Request Functional Test Report for #3359 / a23c004Virtual Devices
Hardware Devices
|
Pull Request Test Coverage Report for Build 12081335950Details
💛 - Coveralls |
self-maurya
force-pushed
the
redisRT1.28
branch
from
9389407 to
441769a
Compare
Member
|
/fptest virtual |
Member
|
/fptest virtual |
ram-mac
reviewed
Nov 28, 2024
...p_isis_redistribution/otg_tests/bgp_isis_redistribution_test/bgp_isis_redistribution_test.go
Show resolved
Hide resolved
...p_isis_redistribution/otg_tests/bgp_isis_redistribution_test/bgp_isis_redistribution_test.go
Show resolved
Hide resolved
Contributor
|
Another request though it is not part changes in this PR 774 //Create prefix-set |
Contributor
Author
|
ram-mac
reviewed
Nov 29, 2024
...p_isis_redistribution/otg_tests/bgp_isis_redistribution_test/bgp_isis_redistribution_test.go
Show resolved
Hide resolved
ram-mac
approved these changes
Nov 29, 2024
Contributor
ram-mac
left a comment
ram-mac
left a comment
There was a problem hiding this comment.
Approved; Have validated the code and it is working fine.
alshabib
pushed a commit
to alshabib/featureprofiles
that referenced
this pull request
Jan 19, 2025
* modifications to RT 1.28 * addressing review comments --------- Co-authored-by: Swetha-haridasula <haridasula@google.com> Co-authored-by: Darren Loher <dloher@google.com> Co-authored-by: Ram <rmachat@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.