test rt1.64 #4397

crc-kt · 2025-07-14T01:48:35Z

Test log: https://partnerissuetracker.corp.google.com/issues/415458482 (contains logs for Arista vendor)

OpenConfigBot · 2025-07-14T01:48:55Z

Pull Request Functional Test Report for #4397 / `3b12eff`

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		RT-1.64: BGP Import/Export Policy (Control plane only) Functional Test Case
Cisco 8000E		RT-1.64: BGP Import/Export Policy (Control plane only) Functional Test Case
Cisco XRd		RT-1.64: BGP Import/Export Policy (Control plane only) Functional Test Case
Juniper ncPTX		RT-1.64: BGP Import/Export Policy (Control plane only) Functional Test Case
Nokia SR Linux		RT-1.64: BGP Import/Export Policy (Control plane only) Functional Test Case
Openconfig Lemming		RT-1.64: BGP Import/Export Policy (Control plane only) Functional Test Case

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		RT-1.64: BGP Import/Export Policy (Control plane only) Functional Test Case
Cisco 8808		RT-1.64: BGP Import/Export Policy (Control plane only) Functional Test Case
Juniper PTX10008		RT-1.64: BGP Import/Export Policy (Control plane only) Functional Test Case
Nokia 7250 IXR-10e		RT-1.64: BGP Import/Export Policy (Control plane only) Functional Test Case

Help

ram-mac · 2025-07-22T15:55:47Z

@crc-kt - Have we validated the PR against any vendor so far? If so can you please share the pass log?
I tried to validating this PR against Cisco and it fails.

crc-kt · 2025-07-30T07:12:45Z

@crc-kt - Have we validated the PR against any vendor so far? If so can you please share the pass log? I tried to validating this PR against Cisco and it fails.

Our main setup is Arista based, I will share the logs for that. Did not test on Cisco.

crc-kt · 2025-07-30T14:25:06Z

@crc-kt - Have we validated the PR against any vendor so far? If so can you please share the pass log? I tried to validating this PR against Cisco and it fails.

Please see test log here:
https://partnerissuetracker.corp.google.com/issues/415458482 (contains logs for Arista vendor)

coveralls · 2025-08-12T04:00:31Z

Pull Request Test Coverage Report for Build 17149918806

Details

0 of 13 (0.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.01%) to 12.696%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
internal/cfgplugins/bgp_policy.go	0	13	0.0%

Totals
Change from base Build 17148847807:	-0.01%
Covered Lines:	2111
Relevant Lines:	16627

💛 - Coveralls

feature/bgp/policybase/otg_tests/Import_Export_Policy/bgp_import_export_policy_test.go

ram-mac · 2025-08-12T04:28:38Z

feature/bgp/policybase/otg_tests/Import_Export_Policy/bgp_import_export_policy_test.go

+	otgAdvertisedRoutesv6Net    = []string{"2001:db8:300:100::0", "2001:db8:300:101::0", "2001:db8:400:100::1", "2001:db8:400:101::1"}
+	otgDeniedRoutesv6Net        = []string{"2001:db8:400:100::1", "2001:db8:400:101::1"}
+	otgAdvertisedRoutesv4Prefix = []uint32{32, 32, 32, 32}
+	otgAdvertisedRoutesv6Prefix = []uint32{127, 127, 127, 127}


@crc-kt - i see in the README we have advertised routes mask length as /127 and denied routes mask length as /128
Here we are using /127 only for all routes

ram-mac · 2025-08-12T04:34:47Z

feature/bgp/policybase/otg_tests/Import_Export_Policy/bgp_import_export_policy_test.go

+
+// bgpCreateNbr creates a BGP object with neighbors pointing to ate and returns bgp object.
+func bgpCreateNbr(t *testing.T, bgpParams *bgpTestParams, dut *ondatra.DUTDevice) *oc.NetworkInstance_Protocol {
+	t.Helper()


@crc-kt - Can we use cfgplugins to create a new bgp session? sample below

For eg:
bs := cfgplugins.NewBGPSession(t, cfgplugins.PortCount2, nil)

https://github.com/openconfig/featureprofiles/blob/3bb2a9387cfc0dab163e458dc87f94351a187bc7/feature/bgp/policybase/otg_tests/aspath_test/aspath_test.go#L221C1-L222C1

I tried to use NewBGPSession upon test creation but failed (different errors), so I had to resort to doing it the way I saw it done in multiple other tests. If you want, I can try to refactor the BGP code but this comes second to new test development so it will probably have delays. Your call.

ram-mac · 2025-08-20T04:50:57Z

@crc-kt - I ran this test on my setup and the test is actually failing. Have you run this test with the recent changes and working for you?

[third_party/openconfig/featureprofiles/internal/helpers/helpers.go:136](https://cs.corp.google.com/piper///depot/google3/third_party/openconfig/featureprofiles/internal/helpers/helpers.go?l=136&ws=rmachat/1370&snapshot=36): gnmiClient.Set() with unexpected error: rpc error: code = InvalidArgument desc = error on request {
        update: {
          path: {
            origin: "cli"
          }
          val: {
            ascii_val: "\nip as-path access list aclRegexAsPathAllowed permit ^65000$\nip as-path access list aclRegexAsPathAllowed deny .*\nroute-map FILTER-IN 10\nmatch as-path aclRegexAsPathAllowed\n"
          }
        }
        }: failed to apply: Incomplete token (at token 2: 'access'): CLI command 3 of 8 'ip as-path access list aclRegexAsPathAllowed permit ^65000$' failed: invalid command

ram-mac · 2025-08-20T04:55:27Z

The fail logs are now attached to 415458482

crc-kt · 2025-08-20T07:04:50Z

@crc-kt - I ran this test on my setup and the test is actually failing. Have you run this test with the recent changes and working for you?

[third_party/openconfig/featureprofiles/internal/helpers/helpers.go:136](https://cs.corp.google.com/piper///depot/google3/third_party/openconfig/featureprofiles/internal/helpers/helpers.go?l=136&ws=rmachat/1370&snapshot=36): gnmiClient.Set() with unexpected error: rpc error: code = InvalidArgument desc = error on request {
        update: {
          path: {
            origin: "cli"
          }
          val: {
            ascii_val: "\nip as-path access list aclRegexAsPathAllowed permit ^65000$\nip as-path access list aclRegexAsPathAllowed deny .*\nroute-map FILTER-IN 10\nmatch as-path aclRegexAsPathAllowed\n"
          }
        }
        }: failed to apply: Incomplete token (at token 2: 'access'): CLI command 3 of 8 'ip as-path access list aclRegexAsPathAllowed permit ^65000$' failed: invalid command

Did you use an Arista device? I will re-run and upload the log.

crc-kt · 2025-08-20T15:03:51Z

The fail logs are now attached to 415458482

PASS log attached after typo fix

ram-mac · 2025-08-21T02:35:30Z

The fail logs are now attached to 415458482

PASS log attached after typo fix

What changed? can you please mention in this PR?

crc-kt · 2025-08-21T07:11:01Z

The fail logs are now attached to 415458482

PASS log attached after typo fix

What changed? can you please mention in this PR?

The CLI deviation (for the Arista vendor) for setting the BGP AS Path Set filter had some typos, namely "access list" instead of "access-list" and an extra sequence number for the route-map name where there should have been none (artifacts that somehow crept back in the final commit without my notice). Moreover, since I was playing around with cfgplugins.NewBGPSession that didn't work properly for me, the active (OTG) and passive (DUT) BGP transport modes were mixed at the peer group and AF level. Corrected all of these and uploaded the pass log.

ram-mac · 2025-08-21T07:52:02Z

With the latest changes, i see the test is now passing. Will attach the logs to the bug. 415458482

--- PASS: TestBgpImportExportPolicy (215.77s)
    --- PASS: TestBgpImportExportPolicy/###_RT-1.64.1_Verify_BGP_Peering_without_policy (73.39s)
    --- PASS: TestBgpImportExportPolicy/###_RT-1.64.2_Test_Export_Policy_(Prefix-list_based) (64.17s)
    --- PASS: TestBgpImportExportPolicy/###_RT-1.64.3_Test_Import_Policy_(AS-Path_based) (58.25s)

ram-mac

LGTM

ram-mac · 2025-08-21T10:28:39Z

@crc-kt - Please fix the Static analysis for this PR

crc-kt · 2025-08-21T10:56:09Z

@crc-kt - Please fix the Static analysis for this PR

Done.
Same language that complains about a few bytes of extra memory consumption takes 5 minutes for a local staticcheck and eats through hdd space like crazy, way to go, Go! In mari aquam quaeris.

ram-mac · 2025-08-21T14:41:41Z

@crc-kt - Please fix the Static analysis for this PR

Done. Same language that complains about a few bytes of extra memory consumption takes 5 minutes for a local staticcheck and eats through hdd space like crazy, way to go, Go! In mari aquam quaeris.

This PR fails the rebase check. Can you please try to rebase the PR and repush once again?

crc-kt · 2025-08-22T08:14:49Z

@crc-kt - Please fix the Static analysis for this PR

Done. Same language that complains about a few bytes of extra memory consumption takes 5 minutes for a local staticcheck and eats through hdd space like crazy, way to go, Go! In mari aquam quaeris.

This PR fails the rebase check. Can you please try to rebase the PR and repush once again?

Done. Please rerun the checks from your side

* test rt1.64 * rt-1.64 address PR comments * final rt-1.64 test pr comments * remove unused vars for staticcheck otg-rt-1.64

crc-kt requested a review from a team as a code owner July 14, 2025 01:48

nikki-blr assigned ram-mac Jul 17, 2025

ram-mac assigned crc-kt Jul 22, 2025

crc-kt force-pushed the otg-rt-1.64 branch from d655d7e to 824df7a Compare July 30, 2025 14:09

crc-kt force-pushed the otg-rt-1.64 branch from 824df7a to 66f779d Compare July 31, 2025 06:57

crc-kt force-pushed the otg-rt-1.64 branch from 66f779d to d2408d4 Compare August 7, 2025 20:53

ram-mac requested changes Aug 12, 2025

View reviewed changes

crc-kt requested a review from a team as a code owner August 19, 2025 15:20

crc-kt force-pushed the otg-rt-1.64 branch from 98195e4 to 71fd382 Compare August 19, 2025 15:21

crc-kt requested a review from ram-mac August 19, 2025 15:22

crc-kt force-pushed the otg-rt-1.64 branch from 71fd382 to e4a7947 Compare August 20, 2025 07:02

crc-kt force-pushed the otg-rt-1.64 branch from c3ac057 to 521ef7e Compare August 20, 2025 13:57

crc-kt force-pushed the otg-rt-1.64 branch from 521ef7e to 967822d Compare August 21, 2025 07:11

ram-mac approved these changes Aug 21, 2025

View reviewed changes

crc-kt force-pushed the otg-rt-1.64 branch from 63f8c15 to d548bfc Compare August 21, 2025 10:56

crc-kt added 4 commits August 22, 2025 07:27

test rt1.64

869ef0b

rt-1.64 address PR comments

348cf5a

final rt-1.64 test pr comments

b59000a

remove unused vars for staticcheck otg-rt-1.64

3b12eff

crc-kt force-pushed the otg-rt-1.64 branch from d548bfc to 3b12eff Compare August 22, 2025 08:11

ram-mac merged commit 634c13f into openconfig:main Aug 22, 2025
14 checks passed

nsadhasivam pushed a commit to nsadhasivam/featureprofiles that referenced this pull request Sep 3, 2025

test rt1.64 (openconfig#4397)

40531da

* test rt1.64 * rt-1.64 address PR comments * final rt-1.64 test pr comments * remove unused vars for staticcheck otg-rt-1.64

nsadhasivam pushed a commit to nsadhasivam/featureprofiles that referenced this pull request Oct 26, 2025

test rt1.64 (openconfig#4397)

508ac92

* test rt1.64 * rt-1.64 address PR comments * final rt-1.64 test pr comments * remove unused vars for staticcheck otg-rt-1.64

test rt1.64 #4397

test rt1.64 #4397

Uh oh!

Conversation

crc-kt commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OpenConfigBot commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Functional Test Report for #4397 / 3b12eff

Virtual Devices

Hardware Devices

Uh oh!

ram-mac commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

crc-kt commented Jul 30, 2025

Uh oh!

crc-kt commented Jul 30, 2025

Uh oh!

coveralls commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 17149918806

Details

💛 - Coveralls

Uh oh!

Uh oh!

ram-mac Aug 12, 2025

Choose a reason for hiding this comment

Uh oh!

crc-kt Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

ram-mac Aug 12, 2025

Choose a reason for hiding this comment

Uh oh!

crc-kt Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

ram-mac commented Aug 20, 2025

Uh oh!

ram-mac commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

crc-kt commented Aug 20, 2025

Uh oh!

crc-kt commented Aug 20, 2025

Uh oh!

ram-mac commented Aug 21, 2025

Uh oh!

crc-kt commented Aug 21, 2025

Uh oh!

ram-mac commented Aug 21, 2025

Uh oh!

ram-mac left a comment

Choose a reason for hiding this comment

Uh oh!

ram-mac commented Aug 21, 2025

Uh oh!

crc-kt commented Aug 21, 2025

Uh oh!

ram-mac commented Aug 21, 2025

Uh oh!

crc-kt commented Aug 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

crc-kt commented Jul 14, 2025 •

edited

Loading

OpenConfigBot commented Jul 14, 2025 •

edited

Loading

Pull Request Functional Test Report for #4397 / `3b12eff`

ram-mac commented Jul 22, 2025 •

edited

Loading

coveralls commented Aug 12, 2025 •

edited

Loading

ram-mac commented Aug 20, 2025 •

edited

Loading