Geokamel/isis scale test #4716
Geokamel/isis scale test #4716
Conversation
|
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
Pull Request Test Coverage Report for Build 18754903250Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Pull Request Functional Test Report for #4716 / 5d6a32dVirtual Devices
Hardware Devices
|
dplore
left a comment
dplore
left a comment
There was a problem hiding this comment.
This was reviewed internally already, so there are few comments from me here. I added a few minor comments
* Adding the full ISIS scale test * correcting the import lib * Modifiying the Readme to add the Dynamic test * Update otgisistopology.go * minor change * some changes * minor stuff * Update isis_scale_test.go * some formating * updating the proto file * minor changes * Final commit * minor change * Final Final
|
@geokamel-eg @rohit-rp - Has anyone ran this? It generates ~150MB of buffer output/log writes. |
Yes , I ran it many times successfully . You can see also in the above logs that it ran with no issue on Nokia VM |
I'm not disputing the result itself, mostly that this is a VERY verbose test, probably unnecessarily so. |
The output/log of 150MB is mainly coming from the IXIA file size (I guess it was 60MBs x 2 tests) , this is because of the scale nature of the test where we need to create a virtual ISIS network on IXIA with all the related links/IPs/Lo0 ...etc . |
* Adding the full ISIS scale test * correcting the import lib * Modifiying the Readme to add the Dynamic test * Update otgisistopology.go * minor change * some changes * minor stuff * Update isis_scale_test.go * some formating * updating the proto file * minor changes * Final commit * minor change * Final Final
* Adding the full ISIS scale test * correcting the import lib * Modifiying the Readme to add the Dynamic test * Update otgisistopology.go * minor change * some changes * minor stuff * Update isis_scale_test.go * some formating * updating the proto file * minor changes * Final commit * minor change * Final Final
6 participants
Adding the final code for the
1 - ISIS Scale Static test
2 - ISIS Scale Dynamic test