Skip to content

System profile#5

Merged
bstoll merged 15 commits intomainfrom
system-profile
Jan 7, 2022
Merged

System profile#5
bstoll merged 15 commits intomainfrom
system-profile

Conversation

@bstoll
Copy link
Copy Markdown
Collaborator

@bstoll bstoll commented Dec 23, 2021

Initial work on project layout and a basic system profile. Resolves #4.

Copy link
Copy Markdown
Member

@robshakir robshakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a good start, thanks @bstoll.

I wonder whether it's worth splitting this out into the base infrastructure of running the tests and then the test content (although, likely we can commit this and then iterate) since I suspect that there is more discussion to have for the test content than the initial directories and how to run the tests (which will be of benefit for other folks too).

@dplore dplore requested a review from sthesayi January 6, 2022 19:42
@dplore
Copy link
Copy Markdown
Member

dplore commented Jan 6, 2022

LGTM, @sthesayi can you confirm your comments are resolved?

Copy link
Copy Markdown
Contributor

@sthesayi sthesayi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Thanks for addressing the comments!

@bstoll bstoll merged commit 270b8a7 into main Jan 7, 2022
@bstoll bstoll deleted the system-profile branch January 7, 2022 17:02
@hnnagashree
Copy link
Copy Markdown
Collaborator

hnnagashree commented Jul 10, 2024

This resolves #3168 and #3166

This was referenced Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add System Profile

5 participants