Merged
Conversation
sthesayi
reviewed
Dec 23, 2021
robshakir
reviewed
Dec 29, 2021
Member
robshakir
left a comment
There was a problem hiding this comment.
This looks a good start, thanks @bstoll.
I wonder whether it's worth splitting this out into the base infrastructure of running the tests and then the test content (although, likely we can commit this and then iterate) since I suspect that there is more discussion to have for the test content than the initial directories and how to run the tests (which will be of benefit for other folks too).
dplore
reviewed
Dec 30, 2021
dplore
reviewed
Dec 30, 2021
Member
|
LGTM, @sthesayi can you confirm your comments are resolved? |
sthesayi
approved these changes
Jan 7, 2022
Contributor
sthesayi
left a comment
There was a problem hiding this comment.
All good. Thanks for addressing the comments!
Collaborator
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial work on project layout and a basic system profile. Resolves #4.