Remove subtest for management port ACL

[ijernoiu]

Update readme as discussed in issue 460677189

[gemini-code-assist]

Summary of Changes

Hello @ijernoiu, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the acl_update_test README by removing documentation related to a subtest for management port ACLs. This change streamlines the test description and removes an OpenConfig path that is no longer relevant to the documented tests, as discussed in issue 460677189.

Highlights

• Documentation Update: Removed "Sub Test 4" from the acl_update_test README, which described testing ACLs on a management port.
• OpenConfig Path Removal: The /interfaces/interface/state/management path was removed from the OpenConfig Path and RPC Coverage section in the README, aligning with the removal of the management port specific subtest.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5000 / 6131287

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		ACL-1.2: ACL Update (Make-before-break)
Cisco 8000E		ACL-1.2: ACL Update (Make-before-break)
Cisco XRd		ACL-1.2: ACL Update (Make-before-break)
Juniper ncPTX		ACL-1.2: ACL Update (Make-before-break)
Nokia SR Linux		ACL-1.2: ACL Update (Make-before-break)
Openconfig Lemming		ACL-1.2: ACL Update (Make-before-break)

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		ACL-1.2: ACL Update (Make-before-break)
Cisco 8808		ACL-1.2: ACL Update (Make-before-break)
Juniper PTX10008		ACL-1.2: ACL Update (Make-before-break)
Nokia 7250 IXR-10e		ACL-1.2: ACL Update (Make-before-break)

Help

[gemini-code-assist]

Code Review

This pull request removes 'Sub Test 4' from the acl_update_test README, which was designed to test ACLs on a management port. The changes are consistent, removing the subtest description and the corresponding OpenConfig path from the coverage list. I have added one comment regarding a potential inconsistency in the documentation for the minimum DUT platform requirement, which may need an update following this change.

I am having trouble creating individual review comments. Click here to see my feedback.

feature/acl/otg_tests/acl_update_test/README.md (58-61)

With the removal of this subtest, which was the only part of the test plan explicitly mentioning MFF-specific behavior (related to CONTROLLER_CARD components), the 'Minimum DUT platform requirement' of 'MFF' on line 113 may no longer be accurate. To ensure the test documentation is consistent and allows for execution on all applicable hardware, please consider updating this requirement if the test is no longer specific to MFF platforms.

[coveralls]

Pull Request Test Coverage Report for Build 21189477184

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 9.936%

---

Totals
Change from base Build 21189314705:	0.0%
Covered Lines:	2227
Relevant Lines:	22413

---

💛 - Coveralls