Add ICMPv6 layer with echo payload creation

[priyaranjannanda]

• Added creation of an ICMPv6 layer and set an echo payload

[OpenConfigBot]

Pull Request Functional Test Report for #5185 / d597e8d

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		MGT-1: Management HA solution test
Cisco 8000E		MGT-1: Management HA solution test
Cisco XRd		MGT-1: Management HA solution test
Juniper ncPTX		MGT-1: Management HA solution test
Nokia SR Linux		MGT-1: Management HA solution test
Openconfig Lemming		MGT-1: Management HA solution test

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		MGT-1: Management HA solution test
Cisco 8808		MGT-1: Management HA solution test
Juniper PTX10008		MGT-1: Management HA solution test
Nokia 7250 IXR-10e		MGT-1: Management HA solution test

Help

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances network test configurations by introducing support for ICMPv6. It allows for the explicit creation of an ICMPv6 layer with an associated echo payload, which is essential for accurately simulating and testing IPv6 network connectivity and diagnostics within the existing test framework.

Highlights

• ICMPv6 Layer: Added the capability to create an ICMPv6 layer within network flow configurations.
• Echo Payload: Implemented the creation of an echo payload specifically for the new ICMPv6 layer.

Changelog

• feature/system/management/otg_tests/management_ha_test/management_ha_test.go
  • Updated IPv6 flow creation to use ICMPv6 instead of ICMP for echo payloads.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes a bug in the createFlowV6 function. Previously, an ICMPv4 header was being configured for an IPv6 packet. The change to use Icmpv6() and NewFlowIcmpv6Echo() is correct and ensures the generated traffic is a valid ICMPv6 echo request. The variable name has also been improved for clarity. The change is accurate and I have no further suggestions.