RT-1.7 Cisco deviation

[karthikeya-remilla]

Adding BgpRplDirectlyUnderPeerGroupUnsupported deviation , since attaching a RPL policy directly under a BGP peer-group is not supported.
RPL config is only supported under AFI/SAFI for a neighbor or peer-group config.

Bug: https://partnerissuetracker.corp.google.com/issues/490033220

this replaces the obsolete older PR #4627 addressing the same issue.

[OpenConfigBot]

Pull Request Functional Test Report for #5197 / 1d26af5

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		RT-1.7: Local BGP Test
Cisco 8000E		RT-1.7: Local BGP Test
Cisco XRd		RT-1.7: Local BGP Test
Juniper ncPTX		RT-1.7: Local BGP Test
Nokia SR Linux		RT-1.7: Local BGP Test
Openconfig Lemming		RT-1.7: Local BGP Test

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		RT-1.7: Local BGP Test
Cisco 8808		RT-1.7: Local BGP Test
Juniper PTX10008		RT-1.7: Local BGP Test
Nokia 7250 IXR-10e		RT-1.7: Local BGP Test

Help

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new platform-specific deviation for Cisco devices, acknowledging their current inability to apply Route Policy Language (RPL) policies directly to BGP peer-groups. The change ensures that automated tests correctly account for this behavior by conditionally adjusting expected configurations, thereby improving the accuracy and robustness of network device testing against platform limitations.

Highlights

• New Cisco Deviation: Introduced BgpRplDirectlyUnderPeerGroupUnsupported to address a Cisco limitation where Route Policy Language (RPL) policies cannot be directly applied under a BGP peer-group, requiring them to be under AFI/SAFI.
• BGP Test Updates: Modified local_bgp_test.go to conditionally clear BGP peer-group policies when the new deviation is active, ensuring tests correctly reflect device behavior for unsupported configurations.
• Protocol Buffer Definition: Added a new boolean field bgp_rpl_directly_under_peer_group_unsupported to proto/metadata.proto to formally define and support the new deviation.

Changelog

• feature/bgp/tests/local_bgp_test/local_bgp_test.go
  • Added logic to clear export and import policies for peer groups if the BgpRplDirectlyUnderPeerGroupUnsupported deviation is active and the policy is not applied to AFI/SAFI.
• feature/bgp/tests/local_bgp_test/metadata.textproto
  • Enabled the bgp_rpl_directly_under_peer_group_unsupported flag for platform exceptions.
• internal/deviations/deviations.go
  • Implemented the BgpRplDirectlyUnderPeerGroupUnsupported function to check for the new deviation.
• proto/metadata.proto
  • Defined a new boolean field bgp_rpl_directly_under_peer_group_unsupported with field number 387.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces the BgpRplDirectlyUnderPeerGroupUnsupported deviation for Cisco devices, which involves updating the proto definition, adding a deviation helper function, enabling it in test metadata, and adjusting local_bgp_test to handle cases where BGP routing policies cannot be directly attached to a peer group. The implementation is consistent with repository standards, and no security vulnerabilities were found.