Update README.md with right network instance for gRIBI AFT entries

[harprsie-g]

Updated gRIBI AFT entries with right network instance for next_hop and next_hop_group

[OpenConfigBot]

Pull Request Functional Test Report for #5198 / f381979

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		TestID-16.4: gRIBI to BGP Route Redistribution for IPv4
Cisco 8000E		TestID-16.4: gRIBI to BGP Route Redistribution for IPv4
Cisco XRd		TestID-16.4: gRIBI to BGP Route Redistribution for IPv4
Juniper ncPTX		TestID-16.4: gRIBI to BGP Route Redistribution for IPv4
Nokia SR Linux		TestID-16.4: gRIBI to BGP Route Redistribution for IPv4
Openconfig Lemming		TestID-16.4: gRIBI to BGP Route Redistribution for IPv4

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		TestID-16.4: gRIBI to BGP Route Redistribution for IPv4
Cisco 8808		TestID-16.4: gRIBI to BGP Route Redistribution for IPv4
Juniper PTX10008		TestID-16.4: gRIBI to BGP Route Redistribution for IPv4
Nokia 7250 IXR-10e		TestID-16.4: gRIBI to BGP Route Redistribution for IPv4

Help

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the README.md documentation by correcting the network instance assignments within gRIBI AFT entry examples. The changes ensure that the provided configuration snippets accurately reflect the intended network instances for next-hop and next-hop group operations, thereby improving the clarity and functional correctness of the documentation for users implementing gRIBI route redistribution.

Highlights

• gRIBI AFT Entry Correction: Corrected the network_instance from 'TEST_VRF' to 'DEFAULT' for next_hop and next_hop_group ADD and DELETE operations in the gRIBI configuration examples.
• IPv4 Entry Update: Added the next_hop_group_network_instance: { value: "DEFAULT" } field to the ipv4 ADD operation for gRIBI entries to specify the correct network instance for the next-hop group.
• eBGP Configuration Clarification: Updated the description of eBGP configuration to explicitly mention that it is applied within the 'TEST_VRF' network instance.

Changelog

• feature/gribi/otg_tests/gribi_to_bgp_redistribution/README.md
  • Updated gRIBI operation examples to use 'DEFAULT' network instance for next-hop and next-hop group configurations.
  • Added next_hop_group_network_instance field to IPv4 entry operations.
  • Clarified the scope of eBGP configuration within 'TEST_VRF'.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the README.md to reflect the correct network instance (DEFAULT) for gRIBI next_hop and next_hop_group AFT entries. The changes are consistent across the document. I've found a minor typo and a formatting issue in the code blocks that should be addressed to improve clarity and adhere to the repository's documentation standards.

_{Note: Security Review has been skipped due to the limited scope of the PR.}

[gemini-code-assist]

There appears to be a typo in this line. The closing single quote for 'TEST_VRF' is missing.

Suggested change

	* Configure eBGP with ATE in network-instance 'TEST_VRF and apply import/export policies.
	* Configure eBGP with ATE in network-instance 'TEST_VRF' and apply import/export policies.

[gemini-code-assist]

The content of this code block is not valid JSON, although the block is tagged as json. According to the repository's style guide (from CONTRIBUTING.md), test README.md files should follow the test plan template, which specifies that configuration examples should be in JSON format. The current format appears to be a textual representation of protobuf messages. Please consider updating this to be valid JSON.

This issue is also present in other code blocks in this file that are tagged as json or yaml but do not contain valid content for those formats (e.g., lines 251-252, 268-270, 360-361, 374-376, and 469-470).

References

1. The test README.md should be structured following the test plan template, which specifies that configuration examples should be in JSON format. ^(link)