Update README.md with right network instance for gRIBI AFT entries#5200
Update README.md with right network instance for gRIBI AFT entries#5200
Conversation
This PR includes the following test updates: 1. Explicitly configures the eBGP session with the ATE within the TEST_VRF in the first step. 2. Changes the network instance to default for both next-hop-group and next-hop attributes in gRIBI entries. 3. Adds network-instance information to the gRIBI IPv4 entry for the next-hop-group.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the documentation for gRIBI to BGP redistribution tests by correcting network instance references within the example configurations. The changes ensure that the eBGP session setup and gRIBI AFT entries accurately reflect the intended network instance usage, improving the clarity and correctness of the test instructions. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Pull Request Functional Test Report for #5200 / dbb0614Virtual Devices
Hardware Devices
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the README.md to correctly document the network instances used for gRIBI AFT entries. The changes align with the description and seem correct. My review identifies a formatting issue in the code blocks used to display gRIBI operations. There's an inconsistency in the language identifiers used (json vs. yaml), and the content within these blocks is not valid for the specified language. I've added a single comment to address this systemic issue, recommending a consistent and valid format for all related code blocks to improve the documentation's clarity and correctness.
Note: Security Review has been skipped due to the limited scope of the PR.
| 'operation: { op: ADD network_instance: "DEFAULT" next_hop: { index: 1001 next_hop { ip_address: { value: "192.0.2.2" } } } }' | ||
| 'operation: { op: ADD network_instance: "DEFAULT" next_hop_group: { id: 2001 next_hop_group { next_hop { index: 1001 weight: { value: 1 } } } } }' | ||
| 'operation: { op: ADD network_instance: "TEST_VRF" ipv4: { prefix: "198.51.100.1/32" ipv4_entry { next_hop_group: { value: 2001 } next_hop_group_network_instance { value: "DEFAULT" } } } }' |
There was a problem hiding this comment.
The code blocks in this file that show gRIBI operations have inconsistent language identifiers (json vs yaml) and invalid content for the specified language. For example, this block is marked as json but is not valid JSON. To improve correctness and consistency, I recommend using a single language identifier for all these blocks (e.g., yaml) and formatting the content as a valid sequence (e.g., prefixing each line with - ). This issue is present in all similar code blocks throughout the file (e.g., lines 249, 267, 358, 373, 467).
|
@gggsmith to review that the intent is correct. LGTM from a test structure point of view. |
|
@dplore - LGTM from Core, need a stamp from approvers - thanks in advance! |
|
LGTM @singhh07 you can merge when you are ready |
5 participants
This PR includes the following test updates: