acctz-3.1: increase ssh defer sleep for result consistency

[dipchauh]

Increase the defer sleep time to 6s to ensure ssh commands complete before the connection closes and prevent intermittent test failures.
Also added check to not skip shell records

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the reliability of SSH-related tests by extending the post-command delay before closing SSH connections. By increasing the sleep duration, the system ensures that all SSH operations, whether successful or failed CLI commands or shell commands, have fully processed and their outcomes are consistently captured, thereby mitigating intermittent test failures.

Highlights

• SSH Connection Stability: The defer sleep time for SSH connections has been increased from 3 seconds to 6 seconds in test helper functions.
• Test Reliability: This change aims to prevent intermittent test failures by ensuring SSH commands have enough time to complete before the connection is closed.

Changelog

• internal/security/acctz/acctz.go
  • Increased the time.Sleep duration from 3 seconds to 6 seconds in SendSuccessCliCommand.
  • Increased the time.Sleep duration from 3 seconds to 6 seconds in SendFailCliCommand.
  • Increased the time.Sleep duration from 3 seconds to 6 seconds in SendShellCommand.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5218 / ced9ad2

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		ACCTZ-3.1: Record Subscribe Non-gRPC
Cisco 8000E		ACCTZ-3.1: Record Subscribe Non-gRPC
Cisco XRd		ACCTZ-3.1: Record Subscribe Non-gRPC
Juniper ncPTX		ACCTZ-3.1: Record Subscribe Non-gRPC
Nokia SR Linux		ACCTZ-3.1: Record Subscribe Non-gRPC
Openconfig Lemming		ACCTZ-3.1: Record Subscribe Non-gRPC

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		ACCTZ-3.1: Record Subscribe Non-gRPC
Cisco 8808		ACCTZ-3.1: Record Subscribe Non-gRPC
Juniper PTX10008		ACCTZ-3.1: Record Subscribe Non-gRPC
Nokia 7250 IXR-10e		ACCTZ-3.1: Record Subscribe Non-gRPC

Help

[gemini-code-assist]

Code Review

This pull request increases the time.Sleep duration in three helper functions to fix an intermittent test failure. While this may resolve the immediate issue, it relies on non-deterministic timing and violates the repository's style guide which discourages the use of time.Sleep. I've added comments suggesting a refactor towards a more robust, deterministic waiting mechanism, such as polling for the expected accounting records, to improve test reliability and maintainability.