Update link_bandwidth_test.go

[AmrNJ]

Update the WatchAll logic to avoid regressions.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the BGP prefix validation logic within the link_bandwidth_test.go file. The changes aim to enhance the reliability and clarity of how BGP prefixes are monitored and collected from the OTG device, specifically by simplifying the WatchAll predicate and ensuring all prefixes are retrieved after the watch condition is met, thereby preventing potential test regressions.

Highlights

• Test Logic Refinement: Refactored the WatchAll logic in link_bandwidth_test.go to simplify the predicate, focusing solely on the presence of a value.
• BGP Prefix Collection: Changed the method of collecting BGP prefixes from an in-loop approach within WatchAll to a post-WatchAll gnmi.GetAll call.
• Error Messaging: Improved the error message for prefix installation failures on the OTG port.

Changelog

• feature/bgp/policybase/otg_tests/link_bandwidth_test/link_bandwidth_test.go
  • Simplified the gnmi.WatchAll predicate to only verify the presence of a value.
  • Replaced the incremental collection of bgpPrefixes within the WatchAll callback with a single gnmi.GetAll call after the watch completes.
  • Removed the receivedPrefixes map and its associated logic.
  • Updated the error message for when prefixes are not successfully installed on the OTG port.

Activity

• No human activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5232 / da765e6

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		RT-7.5: BGP Policy - Match and Set Link Bandwidth Community	b41adeff	Log
Cisco 8000E		RT-7.5: BGP Policy - Match and Set Link Bandwidth Community	b8e427e2	Log
Cisco XRd		RT-7.5: BGP Policy - Match and Set Link Bandwidth Community	7fc08195	Log
Juniper ncPTX		RT-7.5: BGP Policy - Match and Set Link Bandwidth Community	eec4e80c	Log
Nokia SR Linux		RT-7.5: BGP Policy - Match and Set Link Bandwidth Community	6f6ed14e	Log
Openconfig Lemming		RT-7.5: BGP Policy - Match and Set Link Bandwidth Community	cae5fe6b	Log

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		RT-7.5: BGP Policy - Match and Set Link Bandwidth Community
Cisco 8808		RT-7.5: BGP Policy - Match and Set Link Bandwidth Community
Juniper PTX10008		RT-7.5: BGP Policy - Match and Set Link Bandwidth Community
Nokia 7250 IXR-10e		RT-7.5: BGP Policy - Match and Set Link Bandwidth Community

Help

[gemini-code-assist]

Code Review

The code changes in link_bandwidth_test.go refactor the BGP prefix validation logic. Previously, the gnmi.WatchAll function attempted to both wait for a specific count of prefixes and collect them. The updated code simplifies gnmi.WatchAll to only confirm the presence of any BGP prefix, and then explicitly uses gnmi.GetAll to retrieve all currently advertised prefixes. This separates the waiting and data collection steps, removing intermediate data structures from the WatchAll callback.