Skip to content

RT-1.26: Basic static route support-Removing deviation#5233

Open
divyarema wants to merge 1 commit intoopenconfig:mainfrom
divyarema:static_RT1.26
Open

RT-1.26: Basic static route support-Removing deviation#5233
divyarema wants to merge 1 commit intoopenconfig:mainfrom
divyarema:static_RT1.26

Conversation

@divyarema
Copy link
Contributor

Removed deviation ipv6_static_route_with_ipv4_nh_unsupported for juniper

@divyarema divyarema requested a review from a team as a code owner March 17, 2026 17:15
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the test configuration for Juniper devices by removing a specific deviation related to IPv6 static routes with IPv4 next-hops. This change aims to enable or validate support for this network configuration, indicating that Juniper devices are now expected to handle such scenarios without this particular limitation.

Highlights

  • Deviation Removal: The ipv6_static_route_with_ipv4_nh_unsupported deviation has been removed for Juniper devices in the metadata.textproto file.
Changelog
  • feature/staticroute/otg_tests/basic_static_route_support_test/metadata.textproto
    • Removed the ipv6_static_route_with_ipv4_nh_unsupported: true entry from the deviations block for Juniper.
Activity
  • No specific activity or comments have been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the ipv6_static_route_with_ipv4_nh_unsupported deviation for Juniper devices. This change correctly reflects that Juniper platforms now support IPv6 static routes with IPv4 next-hops, and will enable the corresponding test case for this vendor. The change is straightforward and correct.

@OpenConfigBot
Copy link

Pull Request Functional Test Report for #5233 / 60d6d46

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
RT-1.26: Basic static route support
Cisco 8000E status
RT-1.26: Basic static route support
Cisco XRd status
RT-1.26: Basic static route support
Juniper ncPTX status
RT-1.26: Basic static route support
Nokia SR Linux status
RT-1.26: Basic static route support
Openconfig Lemming status
RT-1.26: Basic static route support

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
RT-1.26: Basic static route support
Cisco 8808 status
RT-1.26: Basic static route support
Juniper PTX10008 status
RT-1.26: Basic static route support
Nokia 7250 IXR-10e status
RT-1.26: Basic static route support

Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants