Fix hiba_authentication, host_certificate test for Nokia#5267
Fix hiba_authentication, host_certificate test for Nokia#5267ram-mac merged 2 commits intoopenconfig:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves test failures on Nokia devices by introducing a specific deviation for SSH server host certificate telemetry. As Nokia platforms do not support this telemetry, the affected test assertions in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces the ssh_server_host_certificate_telemetry_unsupported deviation to allow skipping SSH server host certificate telemetry checks on unsupported platforms, specifically targeting Nokia. The hiba_authentication and host_certificates tests were updated to utilize this deviation, and hostCertificateVersion was converted to a constant. Review feedback suggests broadening the documentation comments for the deviation to include all affected telemetry paths and removing an extra blank line in the proto file for consistency.
Added the deviation for the ssh server telemetry which is not supported by Nokia.
Reference bugs are already given in the metadata.proto