Skip to content

Fix hiba_authentication, host_certificate test for Nokia#5267

Merged
ram-mac merged 2 commits intoopenconfig:mainfrom
ram-mac:hiba_auth_host_cert_fix_nokia
Mar 26, 2026
Merged

Fix hiba_authentication, host_certificate test for Nokia#5267
ram-mac merged 2 commits intoopenconfig:mainfrom
ram-mac:hiba_auth_host_cert_fix_nokia

Conversation

@ram-mac
Copy link
Copy Markdown
Contributor

@ram-mac ram-mac commented Mar 26, 2026

Added the deviation for the ssh server telemetry which is not supported by Nokia.
Reference bugs are already given in the metadata.proto

@ram-mac ram-mac requested review from a team as code owners March 26, 2026 16:38
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves test failures on Nokia devices by introducing a specific deviation for SSH server host certificate telemetry. As Nokia platforms do not support this telemetry, the affected test assertions in the hiba_authentication and host_certificates test suites are now conditionally executed, preventing failures on Nokia while preserving full test coverage for other compatible platforms. This enhancement improves the overall reliability and platform compatibility of the test infrastructure.

Highlights

  • New Deviation Introduced: A new deviation, ssh_server_host_certificate_telemetry_unsupported, has been added to account for Nokia devices that do not support SSH server host certificate telemetry.
  • Conditional Test Execution: The hiba_authentication_test.go and host_certificates_test.go files were updated to conditionally skip SSH server telemetry checks if the new deviation is active for the device under test (DUT).
  • Host Certificate Version Update: The hostCertificateVersion in hiba_authentication_test.go was changed from a dynamically generated value to a fixed string constant "v1.0".
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the ssh_server_host_certificate_telemetry_unsupported deviation to allow skipping SSH server host certificate telemetry checks on unsupported platforms, specifically targeting Nokia. The hiba_authentication and host_certificates tests were updated to utilize this deviation, and hostCertificateVersion was converted to a constant. Review feedback suggests broadening the documentation comments for the deviation to include all affected telemetry paths and removing an extra blank line in the proto file for consistency.

Copy link
Copy Markdown
Member

@mihirpitale-googler mihirpitale-googler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Contributor

@singhavnish2516 singhavnish2516 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@singhavnish2516 singhavnish2516 self-assigned this Mar 26, 2026
@ram-mac ram-mac merged commit aa825c4 into openconfig:main Mar 26, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants