Removed juniper specific changes RotateAuthorizedKey

[ram-mac]

Remove the Juniper-specific special case in RotateTrustedUserCA that was adding the SSH algorithm prefix to the AuthorizedKey field. According to the gNSI Credentialz proto definition, this field should only contain the base64-encoded key.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request cleans up the RotateTrustedUserCA function by removing vendor-specific handling for Juniper devices. By standardizing the key format to match the gNSI Credentialz proto definition, the implementation ensures consistent behavior across different hardware vendors.

Highlights

• Removed Juniper-specific logic: Deleted the conditional block that prepended SSH algorithm prefixes to the AuthorizedKey field for Juniper devices.
• Alignment with gNSI standards: Ensured the AuthorizedKey field strictly contains the base64-encoded key as per the gNSI Credentialz protocol definition.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5308 / e51c67f

No tests identified for validation.

Help

[gemini-code-assist]

Code Review

This pull request simplifies the RotateTrustedUserCA function in internal/security/credz/credz.go by removing vendor-specific logic that previously handled Juniper devices differently when processing public keys. A review comment identifies that the pull request metadata is inconsistent with the actual code changes, as the title and description incorrectly refer to RotateAuthorizedKey and the AuthorizedKey field instead of the modified RotateTrustedUserCA function and PublicKey field.

I am having trouble creating individual review comments. Click here to see my feedback.

internal/security/credz/credz.go (265-267)

The pull request title and description contain inconsistencies regarding the function and field being modified. The title mentions RotateAuthorizedKey, and the description refers to the AuthorizedKey field, but the code changes are actually within RotateTrustedUserCA affecting the PublicKey field. Please update the PR metadata to accurately reflect the changes to avoid confusion for future maintainers.