TE-17.1 and RT-1.8: refactor raw vendor checks into deviations

[karthikeya-remilla]

Bug for deviation: https://partnerissuetracker.corp.google.com/u/0/issues/500609711

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors BGP configuration logic by replacing explicit vendor-specific checks with a centralized deviation mechanism. This improves maintainability and allows for cleaner handling of platform-specific requirements when establishing BGP neighborship, specifically regarding the use of interface names versus IPv4 addresses for transport local addresses.

Highlights

• New Deviation Added: Introduced a new deviation 'use_interface_name_for_ibgp_neighbor_transport_ipv4_local_address' to handle specific vendor requirements for BGP transport configuration.
• Code Refactoring: Replaced hardcoded vendor checks with the newly created deviation in BGP session and neighbor configuration logic.
• Documentation and Metadata: Updated metadata definitions and generated protobuf files to support the new deviation flag.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5322 / 196c95b

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		RT-1.8: BGP Route Reflector Test at scale TE-17.1: VRF selection policy driven TE
Cisco 8000E		RT-1.8: BGP Route Reflector Test at scale TE-17.1: VRF selection policy driven TE
Cisco XRd		RT-1.8: BGP Route Reflector Test at scale TE-17.1: VRF selection policy driven TE
Juniper ncPTX		RT-1.8: BGP Route Reflector Test at scale TE-17.1: VRF selection policy driven TE
Nokia SR Linux		RT-1.8: BGP Route Reflector Test at scale TE-17.1: VRF selection policy driven TE
Openconfig Lemming		RT-1.8: BGP Route Reflector Test at scale TE-17.1: VRF selection policy driven TE

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		RT-1.8: BGP Route Reflector Test at scale TE-17.1: VRF selection policy driven TE
Cisco 8808		RT-1.8: BGP Route Reflector Test at scale TE-17.1: VRF selection policy driven TE
Juniper PTX10008		RT-1.8: BGP Route Reflector Test at scale TE-17.1: VRF selection policy driven TE
Nokia 7250 IXR-10e		RT-1.8: BGP Route Reflector Test at scale TE-17.1: VRF selection policy driven TE

Help

[gemini-code-assist]

Code Review

This pull request introduces a new deviation, UseInterfaceNameForIBGPNeighborTransportIpv4LocalAddress, which allows specifying an interface name instead of an IPv4 address for BGP neighbor transport local addresses. The implementation includes updates to metadata.proto, the addition of an accessor in deviations.go, and the application of this deviation in route_reflector_scale_test.go and vrf_policy_driven_te_test.go to replace vendor-specific logic. A minor typo in a test name was also corrected. I have no feedback to provide.