Addressing acctz deviations for juniper

[Eeramma]

Addressing acctz deviations for juniper. Added deviations for failuser access acctz record for gRPC and non-grpc validations.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces new deviation flags to the testing framework to account for specific behaviors on Juniper platforms regarding accounting records for failed user authentication attempts. By incorporating these flags into the metadata and updating the relevant test logic, the changes ensure that test suites can gracefully handle scenarios where these records are not supported, preventing false negatives in validation tests.

Highlights

• New Deviations Added: Introduced two new deviations, acctz_record_fail_command_unsupported and acctz_record_fail_grpc_unsupported, to handle specific Juniper platform limitations.
• Test Logic Updates: Updated test suites to conditionally skip accounting record validation for failed commands and gRPC services when the new deviations are active.
• Metadata and Proto Updates: Updated metadata.proto and associated generated files to include the new deviation flags and configured the test metadata to apply these deviations for Juniper devices.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5324 / 4484023

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		ACCTZ-1.1: Record Subscribe Full ACCTZ-3.1: Record Subscribe Non-gRPC ACCTZ-2.1: Record Subscribe Partial
Cisco 8000E		ACCTZ-1.1: Record Subscribe Full ACCTZ-3.1: Record Subscribe Non-gRPC ACCTZ-2.1: Record Subscribe Partial
Cisco XRd		ACCTZ-1.1: Record Subscribe Full ACCTZ-3.1: Record Subscribe Non-gRPC ACCTZ-2.1: Record Subscribe Partial
Juniper ncPTX		ACCTZ-1.1: Record Subscribe Full ACCTZ-3.1: Record Subscribe Non-gRPC ACCTZ-2.1: Record Subscribe Partial
Nokia SR Linux		ACCTZ-1.1: Record Subscribe Full ACCTZ-3.1: Record Subscribe Non-gRPC ACCTZ-2.1: Record Subscribe Partial
Openconfig Lemming		ACCTZ-1.1: Record Subscribe Full ACCTZ-3.1: Record Subscribe Non-gRPC ACCTZ-2.1: Record Subscribe Partial

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		ACCTZ-1.1: Record Subscribe Full ACCTZ-3.1: Record Subscribe Non-gRPC ACCTZ-2.1: Record Subscribe Partial
Cisco 8808		ACCTZ-1.1: Record Subscribe Full ACCTZ-3.1: Record Subscribe Non-gRPC ACCTZ-2.1: Record Subscribe Partial
Juniper PTX10008		ACCTZ-1.1: Record Subscribe Full ACCTZ-3.1: Record Subscribe Non-gRPC ACCTZ-2.1: Record Subscribe Partial
Nokia 7250 IXR-10e		ACCTZ-1.1: Record Subscribe Full ACCTZ-3.1: Record Subscribe Non-gRPC ACCTZ-2.1: Record Subscribe Partial

Help

[gemini-code-assist]

Code Review

This pull request introduces two new deviations, acctz_record_fail_command_unsupported and acctz_record_fail_grpc_unsupported, to allow skipping accounting record validation for failed user attempts on unsupported platforms. The changes span test metadata, the deviations library, and core accounting test utilities. Review feedback identifies a compilation error in record_subscribe_non_grpc_test.go due to a missing function argument and notes several documentation inaccuracies in deviations.go where the wrong vendor and function names were referenced in comments.