Added missing entries in test registry and also fixing some discrepancies in test plan id#5337
Conversation
…cies in test plan id
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the organization and accuracy of the test suite registry. It introduces new entries for previously unlisted tests and standardizes naming conventions for test plan identifiers across documentation and metadata files to ensure better traceability and consistency within the repository. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request standardizes the casing of 'gNMI' across documentation and metadata, cleans up formatting in test plan IDs, and adds several new test entries to the registry. The review feedback suggests removing leftover markdown formatting in a description field and reordering the new registry entries to maintain lexicographical consistency.
| uuid: "df395a7c-8b43-4b4b-aac8-14dff3097774" | ||
| plan_id: "**RT-7.51" | ||
| plan_id: "RT-7.51" | ||
| description: "BGP Auto-Generated Link-Bandwidth Community**" |
There was a problem hiding this comment.
The description contains trailing asterisks **, which appear to be a leftover from markdown formatting. These should be removed for consistency with the fix applied to the plan_id field.
| description: "BGP Auto-Generated Link-Bandwidth Community**" | |
| description: "BGP Auto-Generated Link-Bandwidth Community" |
testregistry.textproto
Outdated
| test: { | ||
| id: "gNMI-1.24" | ||
| description: "gNMI Leaf-List Update Test" | ||
| readme: "https://github.com/openconfig/featureprofiles/blob/main/feature/gnmi/tests/leaflist_update_test/README.md" | ||
| } | ||
| test: { | ||
| id: "gNMI-1.2" | ||
| description: "Benchmarking: Full Configuration Replace" | ||
| readme: "https://github.com/openconfig/featureprofiles/blob/main/feature/gnmi/tests/full_configuration_replace_test/README.md" | ||
| } | ||
| test: { | ||
| id: "gNMI-1.3" | ||
| description: "Benchmarking: Drained Configuration Convergence Time" | ||
| readme: "https://github.com/openconfig/featureprofiles/blob/main/feature/gnmi/otg_tests/drained_configuration_convergence_time/README.md" | ||
| } |
There was a problem hiding this comment.
The newly added test entries for gNMI-1.2, gNMI-1.3, and gNMI-1.24 are out of order. To maintain consistency with the lexicographical sorting used in this registry (e.g., gNMI-1.23 followed by gNMI-1.4), these should be ordered as gNMI-1.2, gNMI-1.24, and then gNMI-1.3.
| test: { | |
| id: "gNMI-1.24" | |
| description: "gNMI Leaf-List Update Test" | |
| readme: "https://github.com/openconfig/featureprofiles/blob/main/feature/gnmi/tests/leaflist_update_test/README.md" | |
| } | |
| test: { | |
| id: "gNMI-1.2" | |
| description: "Benchmarking: Full Configuration Replace" | |
| readme: "https://github.com/openconfig/featureprofiles/blob/main/feature/gnmi/tests/full_configuration_replace_test/README.md" | |
| } | |
| test: { | |
| id: "gNMI-1.3" | |
| description: "Benchmarking: Drained Configuration Convergence Time" | |
| readme: "https://github.com/openconfig/featureprofiles/blob/main/feature/gnmi/otg_tests/drained_configuration_convergence_time/README.md" | |
| } | |
| test: { | |
| id: "gNMI-1.2" | |
| description: "Benchmarking: Full Configuration Replace" | |
| readme: "https://github.com/openconfig/featureprofiles/blob/main/feature/gnmi/tests/full_configuration_replace_test/README.md" | |
| } | |
| test: { | |
| id: "gNMI-1.24" | |
| description: "gNMI Leaf-List Update Test" | |
| readme: "https://github.com/openconfig/featureprofiles/blob/main/feature/gnmi/tests/leaflist_update_test/README.md" | |
| } | |
| test: { | |
| id: "gNMI-1.3" | |
| description: "Benchmarking: Drained Configuration Convergence Time" | |
| readme: "https://github.com/openconfig/featureprofiles/blob/main/feature/gnmi/otg_tests/drained_configuration_convergence_time/README.md" | |
| } |
…cies in test plan id
…cies in test plan id
…cies in test plan id
|
Please add run data. Also because the README for |
4 participants
…