Changes for coverage of fabric FT#5351
Conversation
…ers by component type in fabric redundancy test
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new test case to validate fabric error telemetry, ensuring that critical error counters are correctly reported by the device. To support this, the PR updates the infrastructure to include a new functional translator deviation, allowing for proper handling of non-standard OpenConfig paths required for this telemetry. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pull Request Functional Test Report for #5351 / ecfb6abVirtual Devices
Hardware Devices
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new test case to verify the presence of fabric error counters, including the necessary helper functions, metadata deviations, and documentation updates. The review feedback highlights a compilation error due to a missing import, potential panic scenarios from unsafe pointer dereferences and map accesses, and brittle logic used for component identification and path parsing.
…emetry test execution logic
No description provided.