Skip to content

Changes for coverage of fabric FT#5351

Merged
RishabhAgarwal-2001 merged 10 commits into
mainfrom
rishabh/fabric-ft
Apr 27, 2026
Merged

Changes for coverage of fabric FT#5351
RishabhAgarwal-2001 merged 10 commits into
mainfrom
rishabh/fabric-ft

Conversation

@RishabhAgarwal-2001
Copy link
Copy Markdown
Contributor

No description provided.

@RishabhAgarwal-2001 RishabhAgarwal-2001 self-assigned this Apr 17, 2026
@RishabhAgarwal-2001 RishabhAgarwal-2001 requested review from a team as code owners April 17, 2026 07:09
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new test case to validate fabric error telemetry, ensuring that critical error counters are correctly reported by the device. To support this, the PR updates the infrastructure to include a new functional translator deviation, allowing for proper handling of non-standard OpenConfig paths required for this telemetry.

Highlights

  • New Fabric Error Telemetry Test: Added a new test case to verify the presence of fabric error counters, including both plane and port-specific metrics.
  • Infrastructure Updates: Introduced a new fabric_ft deviation to support functional translation for fabric error telemetry and updated the metadata schema accordingly.
  • Documentation: Updated the README to include the new test case for fabric error counters.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot
Copy link
Copy Markdown

OpenConfigBot commented Apr 17, 2026

Pull Request Functional Test Report for #5351 / ecfb6ab

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
gNMI-1.16: Fabric redundnacy test
508ea408 Log
Cisco 8000E status
gNMI-1.16: Fabric redundnacy test
1bbdaee3 Log
Cisco XRd status
gNMI-1.16: Fabric redundnacy test
b0715132 Log
Juniper ncPTX status
gNMI-1.16: Fabric redundnacy test
bf3dda3e Log
Nokia SR Linux status
gNMI-1.16: Fabric redundnacy test
dbdd6381 Log
Openconfig Lemming status
gNMI-1.16: Fabric redundnacy test
82e60375 Log

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
gNMI-1.16: Fabric redundnacy test
Cisco 8808 status
gNMI-1.16: Fabric redundnacy test
Juniper PTX10008 status
gNMI-1.16: Fabric redundnacy test
Nokia 7250 IXR-10e status
gNMI-1.16: Fabric redundnacy test

Help

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new test case to verify the presence of fabric error counters, including the necessary helper functions, metadata deviations, and documentation updates. The review feedback highlights a compilation error due to a missing import, potential panic scenarios from unsafe pointer dereferences and map accesses, and brittle logic used for component identification and path parsing.

Comment thread internal/deviations/deviations.go
Comment thread proto/metadata.proto
@RishabhAgarwal-2001 RishabhAgarwal-2001 merged commit cc2398f into main Apr 27, 2026
16 of 19 checks passed
@RishabhAgarwal-2001 RishabhAgarwal-2001 deleted the rishabh/fabric-ft branch April 27, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants