Skip to content

Adding reboot test covering testing bugs#5370

Open
rohit-rp wants to merge 2 commits intoopenconfig:mainfrom
rohit-rp:reboot_test
Open

Adding reboot test covering testing bugs#5370
rohit-rp wants to merge 2 commits intoopenconfig:mainfrom
rohit-rp:reboot_test

Conversation

@rohit-rp
Copy link
Copy Markdown
Contributor

@rohit-rp rohit-rp commented Apr 21, 2026

Coverage for:
http://b/418856223 ISIS database entries going missing after a routing process restart
http://b/286086308 Verify chassis reboots with P4RT active
http://b/399612422 SSH connection to the MFF chassis dropping after a reboot

@rohit-rp rohit-rp requested a review from a team as a code owner April 21, 2026 13:45
@OpenConfigBot
Copy link
Copy Markdown

OpenConfigBot commented Apr 21, 2026

Pull Request Functional Test Report for #5370 / b078b5a

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
System-2.1: DUT Reboot Test
3d123183 Log
Cisco 8000E status
System-2.1: DUT Reboot Test
520751b1 Log
Cisco XRd status
System-2.1: DUT Reboot Test
853844dc Log
Juniper ncPTX status
System-2.1: DUT Reboot Test
6c0a567a Log
Nokia SR Linux status
System-2.1: DUT Reboot Test
b1171699 Log
Openconfig Lemming status
System-2.1: DUT Reboot Test
eb3aa656 Log

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
System-2.1: DUT Reboot Test
Cisco 8808 status
System-2.1: DUT Reboot Test
Juniper PTX10008 status
System-2.1: DUT Reboot Test
Nokia 7250 IXR-10e status
System-2.1: DUT Reboot Test

Help

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces documentation for a new system reboot test designed to verify device stability and control-plane integrity. The test ensures that critical network protocols and connectivity remain functional after a reboot, addressing specific issues related to database entries, chassis reboots, and SSH connectivity.

Highlights

  • New Test Documentation: Added a comprehensive README.md file detailing the procedure for the new DUT reboot test, including pre- and post-reboot validation steps.
  • Test Coverage: The test covers BGP, IS-IS, P4RT, and gNMI connectivity, ensuring system stability and traffic forwarding after a device reboot.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new test plan for the DUT Reboot Test (System-2.1), covering BGP, IS-IS, and redistribution across reboots. The review feedback focuses on aligning the document structure with the repository's mandatory test plan template, including specific header naming conventions and step numbering. Additionally, the reviewer noted that the 'Canonical OC' section needs to be updated to reflect the actual test configuration and the target platform should be corrected to MFF to match the pull request's intent.

Comment thread feature/system/system_base_test/tests/reboot_test/README.md Outdated

#### Initial Setup:

* Connect DUT port-1, 2 to ATE port-1, 2
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Procedure steps should be prefixed with "Step X" (e.g., * Step 1 - ...) to align with the template and the style guide requirement for mapping steps to code comments or logs (line 34).

References
  1. Each step in the test plan procedure should correspond to a comment or t.Log in the code. (link)

Comment thread feature/system/system_base_test/tests/reboot_test/README.md Outdated
* Validate that the traffic is received on ATE port-2

#### Canonical OC
```json
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The "Canonical OC" section appears to be a copy of the template example and is missing the IS-IS and redistribution (table-connections) configuration described in the test procedure. This section should reflect the actual configuration generated by the test.

Comment thread feature/system/system_base_test/tests/reboot_test/README.md Outdated
Comment thread feature/system/system_base_test/tests/reboot_test/README.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants