Skip to content

Update interface state check and add wait after config push#5396

Open
priyaranjannanda wants to merge 2 commits intoopenconfig:mainfrom
priyaranjannanda:TRANSCIVER-107_1
Open

Update interface state check and add wait after config push#5396
priyaranjannanda wants to merge 2 commits intoopenconfig:mainfrom
priyaranjannanda:TRANSCIVER-107_1

Conversation

@priyaranjannanda
Copy link
Copy Markdown
Contributor

This changes include

  • wait after config push before to telemetry stream creation
  • interface state is changed from Down to UP during validation when interfaces are UP

@priyaranjannanda priyaranjannanda requested a review from a team as a code owner April 28, 2026 11:47
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the reliability of transceiver validation tests by introducing necessary delays and adjusting expected state transitions. These changes ensure that telemetry data is fully propagated following configuration updates and that the validation logic correctly reflects the operational status of hardware components.

Highlights

  • Telemetry Synchronization: Added a 120-second sleep after configuration pushes to ensure telemetry streams are correctly updated before validation.
  • Interface State Validation: Updated the expected operational status for temperature sensor telemetry from DOWN to UP to align with actual hardware behavior.
  • Timeout Adjustment: Increased the global validation timeout from 10 minutes to 15 minutes to accommodate slower platform response times.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot
Copy link
Copy Markdown

OpenConfigBot commented Apr 28, 2026

Pull Request Functional Test Report for #5396 / c76295a

No tests identified for validation.

Help

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the transceiver validation logic by increasing the timeout to 15 minutes, changing the expected operational status for temperature sensors to UP, and introducing a 120-second delay after configuration. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants