RT1.26 - fixed the issue

[ASHNA-AGGARWAL-KEYSIGHT]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on stabilizing the IS-IS Graceful Restart test suite by moving away from time-based synchronization to state-based verification. By leveraging gNMI telemetry watches, the tests now accurately track adjacency states and restart statuses, reducing flakiness caused by timing variations in the test environment.

Highlights

• Test Stability Improvements: Replaced hardcoded time.Sleep calls with deterministic telemetry verification using gnmi.WatchAll to improve test reliability.
• Enhanced Telemetry Validation: Introduced verifyAdjRestartState and updated verifyISISTelemetry to support explicit adjacency state checks, including handling of expected DOWN states.
• Configuration Adjustments: Disabled Graceful Restart globally in the test configuration and updated expected neighbor state constants to reflect correct test behavior.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5400 / eb0e889

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		RT-2.16: IS-IS Graceful Restart Helper
Cisco 8000E		RT-2.16: IS-IS Graceful Restart Helper
Cisco XRd		RT-2.16: IS-IS Graceful Restart Helper
Juniper ncPTX		RT-2.16: IS-IS Graceful Restart Helper
Nokia SR Linux		RT-2.16: IS-IS Graceful Restart Helper
Openconfig Lemming		RT-2.16: IS-IS Graceful Restart Helper

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		RT-2.16: IS-IS Graceful Restart Helper
Cisco 8808		RT-2.16: IS-IS Graceful Restart Helper
Juniper PTX10008		RT-2.16: IS-IS Graceful Restart Helper
Nokia 7250 IXR-10e		RT-2.16: IS-IS Graceful Restart Helper

Help

[gemini-code-assist]

Code Review

This pull request refactors the IS-IS Graceful Restart test by replacing static sleep durations with telemetry-based synchronization using gnmi.WatchAll and introduces a flag to verify the absence of adjacencies. The review feedback highlights a potential violation of the test plan due to disabling Graceful Restart, suggests using t.Fatalf for terminal failures, identifies a typo in a parameter name, and recommends improving the adjacency check logic to account for missing telemetry data.