Skip to content

New test case otg enrollz-2#5417

Open
mihaitomaro wants to merge 5 commits intoopenconfig:mainfrom
open-traffic-generator:otg-enrollz-2-clean
Open

New test case otg enrollz-2#5417
mihaitomaro wants to merge 5 commits intoopenconfig:mainfrom
open-traffic-generator:otg-enrollz-2-clean

Conversation

@mihaitomaro
Copy link
Copy Markdown
Contributor

@mihaitomaro mihaitomaro commented May 4, 2026

@mihaitomaro mihaitomaro requested review from a team as code owners May 4, 2026 14:51
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new test suite for validating TPM 1.2 enrollment processes on DUTs. It includes robust test cases for various enrollment scenarios, including error handling for malformed requests and verification of certificate persistence across device reboots. The changes also update the necessary project dependencies and gNSI bindings to facilitate these tests.

Highlights

  • New Test Suite: Added a comprehensive test suite for TPM 1.2 enrollment flows, covering successful enrollment, error handling, and device state persistence.
  • Dependency Update: Added github.com/google/go-tpm to the project dependencies to support TPM-related operations.
  • Binding Update: Updated the GNSI binding to include the Enrollz service client, enabling interaction with the TPM enrollment service.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot
Copy link
Copy Markdown

OpenConfigBot commented May 4, 2026

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new test suite for TPM 1.2 enrollment (Enrollz) within the attestz framework, covering successful enrollment, error handling for invalid requests, and certificate persistence across device reboots. It also updates the project dependencies and extends the GNSI binding to support the Enrollz service. I have no feedback to provide.

@ksgireesha
Copy link
Copy Markdown

@ram-mac , we have LGTM by @seal6363 . Please review and approve this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants