Implementation of Cisco Drop Counters Test

[RishabhAgarwal-2001]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new functional test to validate Cisco-specific pipeline drop counters. It establishes the necessary infrastructure by adding a new deviation field to the metadata schema and implementing a test suite that leverages functional translators to verify drop counter increments under specific traffic conditions, such as L3 route lookup failures and null adjacency drops.

Highlights

• New Test Implementation: Added a new test file pipeline_counters_drop_test.go to verify Cisco vendor-specific drop counters using Open Traffic Generator (OTG).
• Metadata and Deviation Updates: Updated metadata.textproto and proto/metadata.proto to include a new deviation field ciscoxr_vendordrop_ft for handling Cisco XR vendor drop counter functional translation.
• Internal Infrastructure: Updated internal/deviations/deviations.go to expose the new CiscoxrVendordropFt deviation helper.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5455 / 18449e6

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		gNMI-1.29: Pipeline Counters Drops Test	12199505	Log
Cisco 8000E		gNMI-1.29: Pipeline Counters Drops Test	ab93e8ff	Log
Cisco XRd		gNMI-1.29: Pipeline Counters Drops Test	545cc0e3	Log
Juniper ncPTX		gNMI-1.29: Pipeline Counters Drops Test	a4f1c6de	Log
Nokia SR Linux		gNMI-1.29: Pipeline Counters Drops Test	d9f4581f	Log
Openconfig Lemming		gNMI-1.29: Pipeline Counters Drops Test	03fc8256	Log

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		gNMI-1.29: Pipeline Counters Drops Test
Cisco 8808		gNMI-1.29: Pipeline Counters Drops Test
Juniper PTX10008		gNMI-1.29: Pipeline Counters Drops Test
Nokia 7250 IXR-10e		gNMI-1.29: Pipeline Counters Drops Test

Help

[gemini-code-assist]

Code Review

This pull request introduces a new test for Cisco-specific vendor drop counters, including the necessary deviations and metadata updates. The test verifies that specific drop reasons are correctly reported in telemetry. Feedback from the review suggests using t.Fatalf instead of t.Errorf when translation fails to ensure the test fails fast. Additionally, it is recommended to enhance the L3RouteLookupFailed and MPLSLabelMiss subtests by actively triggering traffic drops and verifying that the corresponding counters increment, rather than just checking for their presence.

[rohit-rp]

Address gemini comments plz

[rohit-rp]

@RishabhAgarwal-2001 add pass logs to b/512764000

[RishabhAgarwal-2001]

@RishabhAgarwal-2001 add pass logs to b/512764000

Addressed Gemini comments and have also added pass logs.

Additionally, I have added comments in the test implementation to ensure the FPT-Gap analysis check does not fail