Fixing telemetry_interfaces_test for Nokia

[ram-mac]

Following are the changes
-Counter Validation: Removed the IsZero() check which erroneously failed when counters (like out-errors) were correctly reported as 0.
-Description: Added a logic guard to prevent TEST1 from failing if the description leaf is missing, with MissingValueForDefaults deviation is set
-Rates: Used the StatePathUnsupported deviation which would fix the rate check (TEST3) on Nokia, as the device rejects the in-rate schema path.
-Aggregation Guard: Added a vendor check to skip TEST6 on Nokia physical ports, resolving the [FailedPrecondition] error.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the telemetry_interfaces_test suite to improve compatibility with Nokia (SR Linux) devices. The changes focus on relaxing strict counter validation, adding platform-specific deviations for unsupported paths, and ensuring proper interface initialization to prevent test failures in environments where certain default behaviors or schema paths differ from standard expectations.

Highlights

• Counter Validation: Removed the IsZero() check to prevent false failures when counters are correctly reported as 0.
• Nokia Platform Support: Added Nokia platform exceptions and deviations to handle missing default values, unsupported state paths, and interface configuration requirements.
• Test Robustness: Implemented logic guards and skips for unsupported telemetry paths and aggregation configurations on Nokia devices.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5459 / ee87d05

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		gNMI-1.28: Telemetry: Interface openconfig validation.	2b4089c3	Log
Cisco 8000E		gNMI-1.28: Telemetry: Interface openconfig validation.	d8de88dd	Log
Cisco XRd		gNMI-1.28: Telemetry: Interface openconfig validation.	164f2738	Log
Juniper ncPTX		gNMI-1.28: Telemetry: Interface openconfig validation.	40042fe4	Log
Nokia SR Linux		gNMI-1.28: Telemetry: Interface openconfig validation.	8658ddc5	Log
Openconfig Lemming		gNMI-1.28: Telemetry: Interface openconfig validation.	f2076b87	Log

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		gNMI-1.28: Telemetry: Interface openconfig validation.
Cisco 8808		gNMI-1.28: Telemetry: Interface openconfig validation.
Juniper PTX10008		gNMI-1.28: Telemetry: Interface openconfig validation.
Nokia 7250 IXR-10e		gNMI-1.28: Telemetry: Interface openconfig validation.

Help

[gemini-code-assist]

Code Review

This pull request updates the telemetry interfaces test to improve platform compatibility and reliability. Key changes include adding Nokia platform exceptions in the metadata, refining interface state checks by removing redundant IsZero() calls, introducing conditional skips for unsupported paths, and ensuring mandatory interface type configuration. I have provided feedback regarding the need to extend the IsZero() removal to all relevant subtests and a suggestion to ensure the interface type is consistently set during MAC address configuration.

[singhavnish2516]

Please see the comment before merging.