Skip to content

credz: Force ED25519 key type for HIBA key generation#5464

Open
nkrishk wants to merge 1 commit into
openconfig:mainfrom
nkrishk:krinata2_hiba
Open

credz: Force ED25519 key type for HIBA key generation#5464
nkrishk wants to merge 1 commit into
openconfig:mainfrom
nkrishk:krinata2_hiba

Conversation

@nkrishk
Copy link
Copy Markdown
Contributor

@nkrishk nkrishk commented May 14, 2026

Force ED25519 key type when generating HIBA CA, user, and host keys
via hiba-ca.sh in createHibaKeysGen.

Without an explicit -t ed25519 argument, hiba-ca.sh delegates to
ssh-keygen which may default to a different key type (e.g., RSA).
This causes verification failures since the credentialz test
infrastructure expects ED25519 keys.

Changes:

  • Pass -t ed25519 to all three hiba-ca.sh -c invocations (CA,
    user, and host key generation) in createHibaKeysGen.

@nkrishk nkrishk requested a review from a team as a code owner May 14, 2026 09:35
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses verification failures in the test infrastructure by forcing the use of ED25519 keys during the HIBA key generation process. By explicitly passing the -t ed25519 flag to the underlying ssh-keygen commands, the changes ensure that generated keys are compatible with the expected format, preventing issues caused by varying default key types.

Highlights

  • Enforced Key Type: Updated the HIBA key generation process to explicitly use the ED25519 algorithm for CA, user, and host keys.
  • Test Infrastructure Compatibility: Ensured consistency with the credentialz test suite requirements by preventing default RSA key generation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot
Copy link
Copy Markdown

Pull Request Functional Test Report for #5464 / b50a982

No tests identified for validation.

Help

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the internal/security/credz/credz.go file to explicitly specify the ed25519 key type when generating HIBA CA, user, and DUT keys. This change ensures consistent cryptographic standards across the key generation process. As there were no review comments provided, I have no feedback to offer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants