credz: Force ED25519 key type for HIBA key generation#5464
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses verification failures in the test infrastructure by forcing the use of ED25519 keys during the HIBA key generation process. By explicitly passing the -t ed25519 flag to the underlying ssh-keygen commands, the changes ensure that generated keys are compatible with the expected format, preventing issues caused by varying default key types. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the internal/security/credz/credz.go file to explicitly specify the ed25519 key type when generating HIBA CA, user, and DUT keys. This change ensures consistent cryptographic standards across the key generation process. As there were no review comments provided, I have no feedback to offer.
Force ED25519 key type when generating HIBA CA, user, and host keys
via
hiba-ca.shincreateHibaKeysGen.Without an explicit
-t ed25519argument,hiba-ca.shdelegates tossh-keygenwhich may default to a different key type (e.g., RSA).This causes verification failures since the credentialz test
infrastructure expects ED25519 keys.
Changes:
-t ed25519to all threehiba-ca.sh -cinvocations (CA,user, and host key generation) in
createHibaKeysGen.