Skip to content

Update breakout_subscription_test.go#5481

Merged
AmrNJ merged 8 commits into
mainfrom
AmrNJ-patch-3
May 18, 2026
Merged

Update breakout_subscription_test.go#5481
AmrNJ merged 8 commits into
mainfrom
AmrNJ-patch-3

Conversation

@AmrNJ
Copy link
Copy Markdown
Contributor

@AmrNJ AmrNJ commented May 18, 2026

  1. Add deviation for the below unsupported path.
    /lacp/interfaces/interface/members/member/state/interface

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the breakout subscription test to improve cross-platform compatibility. By introducing a conditional check for LACP interface member state support, the test suite now dynamically adjusts its expectations, ensuring robustness across different device implementations.

Highlights

  • Conditional Path Validation: Updated the test to conditionally expect the LACP interface member state path based on device support, preventing failures on platforms where this path is unsupported.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot
Copy link
Copy Markdown

OpenConfigBot commented May 18, 2026

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the TestBreakoutSubscription test to conditionally include the LACP member state interface path in the expected update paths based on a platform deviation. While the logic correctly handles platform-specific limitations, the reviewer noted that the deviation function LACPInterfaceMemberStateInterfaceUnsupported is not yet defined in the internal/deviations package. To resolve this, the deviation must be defined in the proto metadata, the Go code must be regenerated, and the deviation must be enabled in the test's metadata file.

@AmrNJ AmrNJ marked this pull request as ready for review May 18, 2026 06:33
@AmrNJ AmrNJ requested review from a team as code owners May 18, 2026 06:33
@AmrNJ
Copy link
Copy Markdown
Contributor Author

AmrNJ commented May 18, 2026

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new deviation, lacp_interface_member_state_interface_unsupported, to handle devices that do not support specific LACP interface state paths. The changes include updating the metadata proto definition, regenerating the Go protobuf code, adding an accessor function in the deviations package, and updating the test logic to conditionally check for these paths. I have reviewed the comments and identified that both provided suggestions regarding the issue tracker URL format are valid and should be addressed to comply with the repository style guide.

Comment thread internal/deviations/deviations.go
Comment thread proto/metadata.proto
@AmrNJ AmrNJ merged commit b4495b2 into main May 18, 2026
17 of 18 checks passed
@AmrNJ AmrNJ deleted the AmrNJ-patch-3 branch May 18, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants