Update P4rt-5.3

[AmrNJ]

1. Update logic for 400GFRPorts to be similar to the existing 100GFRPorts.
2. Remove deviation deprecated_vlan_id

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the test infrastructure to better support 400G-FR4 network interfaces. By aligning the configuration logic for 400G ports with the established patterns for 100G ports, the changes ensure consistent interface initialization and improved link stability during testing.

Highlights

• 400G-FR4 Port Support: Updated the traceroute packet-in test to include support for 400G-FR4 ports, mirroring the existing logic for 100G-FR ports.
• Link Configuration: Configured auto-negotiation settings specifically for 400G-FR4 ports to ensure stable link establishment and prevent clock-drift.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds support for 400G-FR4 ports in the traceroute packet-in test, including auto-negotiation and speed configurations. The reviewer recommended wrapping the duplex mode, auto-negotiate, and port speed configurations on the DUT with their respective portability deviations to ensure compatibility across different hardware platforms.

[gemini-code-assist]

To ensure portability across different hardware platforms and vendors, we should guard the configuration of DuplexMode, AutoNegotiate, and PortSpeed with their respective deviations: deviations.DuplexModeUnsupported(dut), deviations.AutoNegotiateUnsupported(dut), and deviations.PortSpeedUnsupported(dut).

Suggested change

	if p.PMD() == ondatra.PMD100GBASEFR || p.PMD() == ondatra.PMD400GBASEFR4 {
	e := i.GetOrCreateEthernet()
	e.AutoNegotiate = ygot.Bool(false)
	e.DuplexMode = oc.Ethernet_DuplexMode_FULL
	e.PortSpeed = oc.IfEthernet_ETHERNET_SPEED_SPEED_100GB
	if p.PMD() == ondatra.PMD100GBASEFR {
	e.AutoNegotiate = ygot.Bool(true) // Enable autoneg on 100G Single-Lambda FR!
	e.PortSpeed = oc.IfEthernet_ETHERNET_SPEED_SPEED_100GB
	} else {
	e.AutoNegotiate = ygot.Bool(false) // Keep disabled on 400G PAM4 to prevent clock-drift
	e.PortSpeed = oc.IfEthernet_ETHERNET_SPEED_SPEED_400GB
	}
	}
	if p.PMD() == ondatra.PMD100GBASEFR || p.PMD() == ondatra.PMD400GBASEFR4 {
	e := i.GetOrCreateEthernet()
	if !deviations.DuplexModeUnsupported(dut) {
	e.DuplexMode = oc.Ethernet_DuplexMode_FULL
	}
	if !deviations.AutoNegotiateUnsupported(dut) {
	if p.PMD() == ondatra.PMD100GBASEFR {
	e.AutoNegotiate = ygot.Bool(true)
	} else {
	e.AutoNegotiate = ygot.Bool(false)
	}
	}
	if !deviations.PortSpeedUnsupported(dut) {
	if p.PMD() == ondatra.PMD100GBASEFR {
	e.PortSpeed = oc.IfEthernet_ETHERNET_SPEED_SPEED_100GB
	} else {
	e.PortSpeed = oc.IfEthernet_ETHERNET_SPEED_SPEED_400GB
	}
	}
	}

References

1. Avoid using "dut.Vendor()" for vendor-specific logic or configurations in tests. Instead, use the "deviations" package to maintain test abstraction and portability across different vendors. ^(link)

[OpenConfigBot]

Pull Request Functional Test Report for #5505 / 92a2f6d

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		P4RT-5.3: Traceroute: PacketIn With VRF Selection	8e6893f9	Log
Cisco 8000E		P4RT-5.3: Traceroute: PacketIn With VRF Selection	0a113f0b	Log
Cisco XRd		P4RT-5.3: Traceroute: PacketIn With VRF Selection	04078d4e	Log
Juniper ncPTX		P4RT-5.3: Traceroute: PacketIn With VRF Selection	8de7f2a0	Log
Nokia SR Linux		P4RT-5.3: Traceroute: PacketIn With VRF Selection	d39beb54	Log
Openconfig Lemming		P4RT-5.3: Traceroute: PacketIn With VRF Selection	7000cd04	Log

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		P4RT-5.3: Traceroute: PacketIn With VRF Selection
Cisco 8808		P4RT-5.3: Traceroute: PacketIn With VRF Selection
Juniper PTX10008		P4RT-5.3: Traceroute: PacketIn With VRF Selection
Nokia 7250 IXR-10e		P4RT-5.3: Traceroute: PacketIn With VRF Selection

Help