Remove DisableHardwareNexthopProxy deviation#5528
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request removes a hardware-specific deviation that is no longer necessary for Arista devices to handle MPLS-in-UDP encapsulation correctly. The changes involve cleaning up test code, updating the central metadata definitions, and removing the unused deviation from the registry, ensuring the codebase remains clean and up-to-date with current device capabilities. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the disable_hardware_nexthop_proxy deviation from the codebase. This includes deleting the deviation definition in proto/metadata.proto (and reserving field 345), regenerating the Go proto files, removing the helper accessor in internal/deviations/deviations.go, and removing the corresponding test configurations and logic from the mpls_in_udp and mpls_in_udp_scale tests. I have no feedback to provide as there are no review comments and the changes are clean and complete.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This deviation is no longer needed after the EFT delivered in b/517114446. The DUT no longer requires `ip hardware fib next-hop proxy disabled` CLI config for FIB-ACK to work correctly with MPLS-in-UDP encapsulation. Removed from proto definition, Go helper, deviation registry, and test code in TE-18.1 (mpls_in_udp) and TE-18.3 (mpls_in_udp_scale). Field number 345 is reserved per repo convention. Bug: 460431517
smharis-arista
force-pushed
the
DisableHwNhProxy
branch
from
d5d9614 to
f9bc9fd
Compare
2 participants
This deviation is no longer needed after the EFT delivered in b/517114446. The DUT no longer requires
ip hardware fib next-hop proxy disabledCLI config for FIB-ACK to work correctly with MPLS-in-UDP encapsulation.Removed from proto definition, Go helper, deviation registry, and test code in TE-18.1 (mpls_in_udp) and TE-18.3 (mpls_in_udp_scale). Field number 345 is reserved per repo convention.
Bug: 460431517