Modifying this test to add more comprehensive tests#5651
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the comprehensiveness of the platform telemetry inventory tests by defining and enforcing stricter validation criteria for component health and power consumption. It updates the test documentation and configuration to ensure critical OpenConfig state paths are monitored across relevant hardware components. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pull Request Functional Test Report for #5651 / 8a1517fVirtual Devices
Hardware Devices
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the telemetry inventory test README to include validation requirements and path definitions for component health status (equipment-failure, equipment-mismatch) and power metrics (allocated-power, used-power). It also adds a Canonical OC JSON example. The reviewer noted that the JSON example is missing the 'equipment-mismatch' field, which is required by the documented validation procedure, and provided a suggestion to add it.
| "equipment-failure": false, | ||
| "allocated-power": 350, | ||
| "used-power": 280 |
There was a problem hiding this comment.
The test procedure specifies validation for both equipment-failure and equipment-mismatch under /components/component/state/. However, the Canonical OC JSON example only includes equipment-failure. Please add equipment-mismatch to the example to ensure completeness and consistency with the documented procedure.
| "equipment-failure": false, | |
| "allocated-power": 350, | |
| "used-power": 280 | |
| "equipment-failure": false, | |
| "equipment-mismatch": false, | |
| "allocated-power": 350, | |
| "used-power": 280 |
2 participants
Adding more coverage to address some of Gaps
equipment-failure and equipment-mismatch (should be false).
allocated-power and used-power (ensuring non-zero values for active components).
2.Added the following OpenConfig paths to the test plan:
/components/component/state/allocated-power (for CONTROLLER_CARD, FABRIC, LINECARD, POWER_SUPPLY)
/components/component/state/used-power (for CONTROLLER_CARD, FABRIC, LINECARD, POWER_SUPPLY)
/components/component/state/equipment-failure (for all FRUs)
/components/component/state/equipment-mismatch (for all FRUs)