Skip to content

Adding new test for Port mirroring coverage in FNT#5652

Open
ram-mac wants to merge 4 commits into
openconfig:mainfrom
ram-mac:port_mirroring_test
Open

Adding new test for Port mirroring coverage in FNT#5652
ram-mac wants to merge 4 commits into
openconfig:mainfrom
ram-mac:port_mirroring_test

Conversation

@ram-mac

@ram-mac ram-mac commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Add new test for coverage of Port Mirroring

  • Adding README.md file which outlines the test procedure for local packet mirroring (to FILE action) across physical interfaces and LAG member ports in both ingress and egress directions
  • Adding metadata.textproto which would outlines the TestID and other details

@ram-mac ram-mac requested review from a team as code owners July 2, 2026 04:34
@OpenConfigBot

OpenConfigBot commented Jul 2, 2026

Copy link
Copy Markdown

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new automated test case for verifying packet mirroring functionality in the FNT environment. The test validates the ability to redirect traffic matching specific ACLs to a local file across various interface types, ensuring compliance with OpenConfig mirroring extensions.

Highlights

  • New Test Coverage: Added a new test case for Port Mirroring functionality, covering ingress and egress scenarios on both physical interfaces and LAG member ports.
  • Documentation and Metadata: Included a comprehensive README.md detailing the test procedure and a metadata.textproto file for test identification.
  • Registry Update: Updated the test registry to include the link to the new test documentation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants