Sflow encap decap test#5669
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new test suite designed to validate sFlow sampling behavior when traffic undergoes various encapsulation and decapsulation processes on the DUT. By adding these test cases, the repository improves its coverage of network telemetry features in complex forwarding scenarios, ensuring that sampled packets correctly reflect the expected headers and interface metadata. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces sFlow sampling test plans for various encapsulation and decapsulation scenarios (including GRE, GUE, and gRIBI) across multiple test suites, and adds a new test plan SFLOW-2 specifically dedicated to sFlow sampling with encapsulation and decapsulation. Feedback on the changes suggests removing the newly added GRE encapsulation and decapsulation test cases from the basic sFlow test suite (SFLOW-1) to avoid redundancy with the SFLOW-2 test suite.
| * SFLOW-1.4 sFlow sampling with IPoverGRE Encap | ||
| * Configure IPoverGRE encapsulation on DUT. | ||
| * Enable sFlow sampling on the ingress interface (receiving IP traffic) and egress interface (sending GRE traffic). | ||
| * Send IPv4 traffic from ATE. | ||
| * Verify DUT encapsulates traffic and sends to ATE. | ||
| * Verify sFlow collector receives samples. | ||
| * Verify sFlow sample contains: | ||
| * Ingress interface matches the ingress port. | ||
| * Egress interface matches the egress port. | ||
| * Sampled packet header matches the expected GRE packet. | ||
| * Sampling rate matches configured rate. | ||
|
|
||
| * SFLOW-1.5 sFlow sampling with IPoverGRE Decap | ||
| * Configure IPoverGRE decapsulation on DUT. | ||
| * Enable sFlow sampling on the ingress interface (receiving GRE traffic) and egress interface (sending IP traffic). | ||
| * Send GRE encapsulated IPv4 traffic from ATE. | ||
| * Verify DUT decapsulates traffic and sends to ATE. | ||
| * Verify sFlow collector receives samples. | ||
| * Verify sFlow sample contains: | ||
| * Ingress interface matches the ingress port. | ||
| * Egress interface matches the egress port. | ||
| * Sampled packet header matches the expected packet. | ||
|
|
||
| * SFLOW-1.6 sFlow sampling with IPv6overGRE Encap | ||
| * Configure IPv6overGRE encapsulation on DUT. | ||
| * Enable sFlow sampling on the ingress interface and egress interface. | ||
| * Send IPv6 traffic from ATE. | ||
| * Verify DUT encapsulates traffic and sends to ATE. | ||
| * Verify sFlow collector receives samples. | ||
| * Verify sFlow sample contains: | ||
| * Ingress interface matches the ingress port. | ||
| * Egress interface matches the egress port. | ||
| * Sampled packet header matches the expected GRE packet. | ||
|
|
||
| * SFLOW-1.7 sFlow sampling with IPv6overGRE Decap | ||
| * Configure IPv6overGRE decapsulation on DUT. | ||
| * Enable sFlow sampling on the ingress interface and egress interface. | ||
| * Send GRE encapsulated IPv6 traffic from ATE. | ||
| * Verify DUT decapsulates traffic and sends to ATE. | ||
| * Verify sFlow collector receives samples. | ||
| * Verify sFlow sample contains: | ||
| * Ingress interface matches the ingress port. | ||
| * Egress interface matches the egress port. | ||
| * Sampled packet header matches the expected packet. | ||
|
|
There was a problem hiding this comment.
The test cases SFLOW-1.4 through SFLOW-1.7 added here for GRE encapsulation and decapsulation are identical to SFLOW-2.1 through SFLOW-2.4 defined in the newly added sflow_encap_decap_test/README.md. To avoid redundancy and maintain a clean test suite structure, we should keep SFLOW-1 focused strictly on basic sFlow configuration and plain IP sampling, and consolidate all encapsulation/decapsulation sFlow tests under SFLOW-2. Please remove these duplicated test cases from sflow_base_test/README.md.
2 participants
Sflow encap decap test for b/437422041