Conversation
Member
robshakir
commented
Jun 6, 2021
robshakir
commented
* (M) client/client.go
- TODOs for implementation details that are pending.
* (M) client/client.go
- add handling for receiving messages from a client into
restructured pending and result queues that include more
info including the timestamp and result codes.
* (M) client/client_test.go
- add test coverage for all non-integration parts.
* (M) fluent/fluent.go
- Since the client connection parameters might be across
different RPCs, restructure the fluent client (per the design
doc) to encapsulate the connection parameters.
* (M) fluent/fluent_test.go
- Update existing tests to correspond to absorb the changes
described above.
* (M) client/client.go
* (M) client/client_test.go
- Restructure pneding queues to be able to store the type of
transaction that is pending, not just operations - such that
it is possible to track latency of other operations and ensure
that the client is aware that is has pending non-operations
requests.
- Add a converged method to check whether there are any pending
requests from the server in the client.
* (M) fluent/fluent.go
* (M) fluent/fluent_test.go
- Add initial Await() implementation.
* (A) chk/chk.go
* (A) chk/chk_test.go
- Add a check library that can be used to determine
characteristics of the results that are returned by the client.
This library is a fluent-style helper library for gRIBI client
results to maintain readability of our test cases.
* (M) client/client.go
- Change the modifyCh to be unbuffered such that we have blocking
writes, this is required to ensure that we do not lose messages
and ensure that Await operates as expected.
- Add String debugging output to OpResult.
* (M) fluent/fluent.go
* (M) fluent/fluent_test.go
- Add Results method, and extend testing to results.
* (M) go.mod
* (M) go.sum
- Housekeeping
* (M) server/server.go
* (M) server/server_test.go
- Add support and testing for master election.
* (M) client/client.go
- Avoid appending an empty session parameters request with no
provided parameters.
* (M) fluent/fluent_test.go
- Handle test flake because of timing issues.
* (M) client/client_test.go
- Remove sending empty parameters message when no parameters are
set.
* (M) server/server.go
* (M) server/server_test.go
- Add handling of session parameters validation and checks against
the supported capabilities of the fake.
* (M) client/client.go
* (M) client/client_test.go
- Add new option to allow for persistence to be sent to the server.
- Ensure that a client with errors is marked as converged.
* (M) fluent/fluent.go
* (M) fluent/fluent_test.go
- Plumb persistence through fluent client.
- Add test case to check that a client with errors does not hang
indefinitely.
* (M) server/server.go
* (M) server/server_test.go
- Fix error handling.
* (M) chk/chk.go
- Add removed documentation string.
* (M) .github/workflows/go.yml
- Remove doc from go test -race.
robshakir
changed the title
sthesayi
approved these changes
Jun 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.