Skip to content

Initial implementation of fluent-style API for gribigo.#3

Merged
robshakir merged 3 commits intomainfrom
fluent-0
Jun 2, 2021
Merged

Initial implementation of fluent-style API for gribigo.#3
robshakir merged 3 commits intomainfrom
fluent-0

Conversation

@robshakir
Copy link
Copy Markdown
Member

    Initial implementation of fluent-style API for gribigo.
    
      * (M) client/client.go
      * (M) client/client_test.go
        - Rename client.NewClient to simply client.New to remove
          stuttering in the API call.
      * (A) fluent/fluent.go
      * (A) fluent/fluent_test.go
        - Initial implementation of the fluent API that can be used
          by test authors to test gRIBI functions.
        - Tests in this package also serve as integration tests between
         the client and the server within the package.
      * (M) go.mod
      * (M) go.sum
        - Go module housekeeping.
      * (M) server/server.go
      * (M) server/server_test.go
        - Update server code to move to using New() vs. NewServer() to
          remove stuttering.

This PR fixes the erroneous merge to main directly. Added branch protection for this branch requiring PR reviews so this should not happen again.

robshakir added 3 commits May 27, 2021 20:54
  * (M) client/client_test.go
    - Change client_test to ensure that the test name corresponds
      to what is being tested.
@robshakir robshakir changed the title Fluent 0 Initial implementation of fluent-style API for gribigo. May 28, 2021
@robshakir robshakir requested a review from sthesayi May 28, 2021 07:11
@robshakir robshakir merged commit 1c799a4 into main Jun 2, 2021
@robshakir robshakir deleted the fluent-0 branch June 22, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants