Conversation
Member
robshakir
commented
Jun 18, 2021
robshakir
commented
* (M) aft/oc.go
* (M) aft/update.sh
- Update generated code.
* (M) go.mod
* (M) go.sum
- Go mod tidying.
* (M) rib/rib.go
* (M) rib/rib_test.go
- Add IPv4 entry add and delete.
* (M) go.mod
* (M) go.sum
- Tidy up modules.
* (M) rib/rib.go
* (M) rib/rib_test.go
- Add support for network instances in the RIB rather than
a single RIB.
* (M) client/client.go
- TODO comment about handling coalescing.
* (M) rib/rib.go
* (M) rib/rib_test.go
- Add support for adding NHG and NHs to the RIB.
* (M) rib/rib.go
* (M) rib/rib_test.go
- Validate any candidate RIB against the OpenConfig schema before
adding it to the RIB.
* (M) aft/oc.go
* (M) aft/update.sh
- Add delete methods.
* (M) go.mod
* (M) go.sum
- Tidy up modules.
* (M) rib/rib.go
- Add support for a simple callback function that is run after
every update to the RIB.
- Fix a defect with implicit replace whereby we did not delete the
RIB entry before doing MergeStructInto meaning that for some
leaf-lists we ended up appending to the contents of the RIB.
* (M) rib/rib_test.go
- Add test cases for the above functionality - including a test
case demonstrating how gNMI Notifications can be generated.
* Add an initial implementation of a resolved-RIB.
Background -- we want the gRIBI server to be able build both a RIB that
is efficient for it to do gRIBI operations with, as well as a software
emulated 'resolved RIB' / 'FIB' whereby we can say something like "where
will this packet go based on what gRIBI is programmed?". This package
starts this implementation.
* (M) aft/oc.go
- Update generated code.
* (M) go.mod
* (M) go.sum
- New dependencies on kentik/patricia
* (A) ocrt/oc.go
* (A) ocrt/update.sh
- Generated routing specific OpenConfig Go structs.
* (A) ocrt/yang/deviations.yang
- Deviations to reduce the size of the generated oc.go.
* (M) rib/rib.go
- Fix handling of implicit replace.
* (A) sysrib/sysrib.go
* (A) sysrib/sysrib_test.go
- Initial system RIB implementation. This package currently parses
OpenConfig to build a list of all of the connected routes that
are on the system.
* Address review comments.
* (A) gnmit/gnmit.go
* (A) gnmit/gnmit_test.go
- Wrap the openconfig/gnmi libraries to create a single-device
cache that can be used to send gNMI updates to from the overall
fake device.
* (M) go.mod
* (M) go.sum
- move off ygot development branch.
* (M) rib/rib.go
- Adopt change to protomap API in ygot.
* (M) server/server.go
- Add goroutines to server Modify handler to allow concurrent
processing.
* (M) gnmit/gnmit_test.go
- deflake test by:
- checking for presence of correct leaves before syncresponse.
- ignoring update order.
* (M) fluent/fluent.go
* (M) fluent/fluent_test.go
- Add support for generating basic IPv4Entry types in the
fluent API.
- Ensure coverage of the builder functions in the fluent
library.
* (M) client/client.go
- Fix duplicate queueing for AFTOperations during send queueing.
- Handle received operations from the server by removing them
from the pending queue.
* (M) fluent/fluent.go
- Simplfy mapping to canonical reason codes.
* (M) fluent/fluent_test.go
- Add an integration test for a simple IPv4 entry.
* (M) rib/rib.go
* (M) rib/rib_test.go
- Define a type for the RIB function hook.
- add locking across network instances.
- change ribHolder to be publicly accessible.
* (M) server/server.go
- Define a const for the default network instance name.
- Add handling for specifying a RIBHook when initialising the
server.
- Add handling for doing an IPv4 add operation.
* (M) fluent/fluent.go
* (M) fluent/fluent_test.go
- Make gRIBIClient public so that more reusable tests can be built.
- Add builder for results messages.
* (M) client/client.go - add close method, and operation details to returned messages.
* (M) constants/const.go
- Mapping of constants to protobuf constants.
- fix MODIFY->REPLACE>
sthesayi
approved these changes
Jun 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.