Conversation
Member
robshakir
commented
Jun 20, 2021
robshakir
commented
* (M) rib/rib.go
* (M) rib/rib_test.go
- Add GetRIB function to RIBHolder that iterates through the
contents of the RIB and returns the entries as gRIBI GetResponse
messages via the specified channel.
* (M) rib/rib.go
- Remove proto functions.
* (M) server/server.go
* (M) server/server_test.go
- Add handling of the Get RPC to the server, allowing streaming
of installed entries back to the client.
* (M) rib/rib.go
* (M) rib/rib_test.go
- Add function to add a new network instance to the RIB.
* (M) server/server_test.go
- Add further testing to the Get RPC.
* (M) client/client.go
* (M) client/client_test.go
- Add support for the Get RPC to client.
* (M) rib/rib.go
- Add string representations of the RIBs to allow for debugging
on server instances.
* (M) server/server.go
- Add a FakeServer wrapper allowing state injection.
* (M) fluent/fluent.go
* (M) fluent/fluent_test.go
- Add support for Get to the fluent API with initial builder
pattern. Re-use the same entry types.
* (M) rib/rib.go
* (M) rib/rib_test.go
- Add filter to Get on a particular RIB in order to control
which sets of AFTs are returned.
* (M) server/server.go
* (M) server/server_test.go
- Support the GetRequest->aft field in GetRequest.
Member
Author
|
Re: #34 |
sthesayi
approved these changes
Jun 21, 2021
* (M) chk/chk_test.go
- Use new constants names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.