Conversation
* (M) client/client.go
- Ensure that client runs by default.
- Add logging messages to allow introspection.
* (M) fluent/fluent.go
- Move StartSending to be at the top-level gRIBIClient, we
essentially keep the abstractions at the level of only
having one Modify channel - which seems to make sense
since there doesn't seem to be a clear use case for 1
client to have >1 modify RPC.
* (M) fluent/fluent_test.go
- add test cases whereby some messages are sent on the Modify
RPC. Current tests just ensure that there is no error returned
rather than adding any check of the return value, since server
does not currently do this processing.
* (M) server/server.go
- Add logging into server.
* (M) client/client.go
- Amend failing tests from merge.
* (M) fluent/fluent.go
* (M) fluent/fluent_test.go
- Restructure fluent to be compatible with ONDATRA (adding
testing.TB arguments).
* (M) go.mod
* (M) go.sum
- go mod housekeeping 🧹
* (A) negtest/README.md
* (A) negtest/negtest.go
* (A) negtest/negtest_test.go
- Vendor negtest from ONDATRA and add support for catching
Errorf strings.
* (M) client/client.go
- Fix error in client 'run' state, make this clearer by
changing to shut vs. run.
* (M) fluent/fluent.go
- Fix logging.
* (M) fluent/fluent_test.go
- Amend comment in test code about how errors are caught.
* (M) server/server.go
- Add handling of initial parameters to serer.
* (M) server/server_test.go
- Add testing for handling of parameters.
robshakir
changed the title
sthesayi
approved these changes
Jun 2, 2021
* (M) client/client.go
- fix Pending and Results functions.
* (M) client/client_test.go
- add tests for pending queue and results queue retrieval.
* (M) server/server.go
- Ensure that elecMu field is referenced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CL will be followed up with additional to implement the connection handling
at the server side, such that we can validate the end-to-end initial handshake.