ccli_test dial options for unencrypted gRPC and sending metadata#71
Merged
liulk merged 1 commit intoopenconfig:mainfrom Aug 12, 2021
liulk:topic/cclidialopts
Merged
ccli_test dial options for unencrypted gRPC and sending metadata#71liulk merged 1 commit intoopenconfig:mainfrom liulk:topic/cclidialopts
liulk merged 1 commit intoopenconfig:mainfrom
liulk:topic/cclidialopts
Conversation
robshakir
approved these changes
Aug 12, 2021
Member
robshakir
left a comment
robshakir
left a comment
There was a problem hiding this comment.
LGTM, a couple of minor suggestions.
| addr = flag.String("addr", "", "address of the gRIBI server in the format hostname:port") | ||
| addr = flag.String("addr", "", "address of the gRIBI server in the format hostname:port") | ||
| insecure = flag.Bool("insecure", false, "dial insecure gRPC (no TLS)") | ||
| skipverify = flag.Bool("skipverify", true, "allow self-signed TLS certificate") |
Member
There was a problem hiding this comment.
(nit) Add something here that says that this is not required when "insecure" is also set?
| }, nil | ||
| } | ||
|
|
||
| func (flagCred) RequireTransportSecurity() bool { |
Member
There was a problem hiding this comment.
This looks to be unused. I presume it's required to implement the argument for grpc.WithPerRPCCredentials? I'd suggest to add a comment to flagCred that just states what interface it is implementing.
Contributor
Author
There was a problem hiding this comment.
That's right. Added comment to clarify.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.