fluent exports GRIBIEntry so that a test can stage them before adding.#75
Merged
liulk merged 1 commit intoopenconfig:mainfrom Sep 3, 2021
liulk:topic/fluentexportentry
Merged
fluent exports GRIBIEntry so that a test can stage them before adding.#75liulk merged 1 commit intoopenconfig:mainfrom liulk:topic/fluentexportentry
liulk merged 1 commit intoopenconfig:mainfrom
liulk:topic/fluentexportentry
Conversation
As a result, the opproto() and entryproto() methods have been modified to return a copy rather than sharing a reference, so the caller can safely modify them for use in different operations.
sthesayi
reviewed
Sep 1, 2021
sthesayi
approved these changes
Sep 1, 2021
Contributor
sthesayi
left a comment
sthesayi
left a comment
There was a problem hiding this comment.
Per our discussion and looking at the test case construction and assertion, this change makes more sense. There could be alternative implementations that can avoid exposing GRIBIEntry but that code will look a lot verbose and hard to maintain. Also given this is an interface, I don't see strong reasoning to not approve this change but please do also check with Rob when he returns. Consider this as a provisional approval to unblock test development.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a result, the opproto() and entryproto() methods have been modified
to return a copy rather than sharing a reference, so the caller can
safely modify them for use in different operations.