Skip to content

Add Send method to fluent Get#77

Merged
sthesayi merged 2 commits intoopenconfig:mainfrom
sthesayi:get_rpc
Oct 8, 2021
Merged

Add Send method to fluent Get#77
sthesayi merged 2 commits intoopenconfig:mainfrom
sthesayi:get_rpc

Conversation

@sthesayi
Copy link
Copy Markdown
Contributor

@sthesayi sthesayi commented Oct 8, 2021

Previously the fluent Get() method was only constructing the Get RPC proto message but was not sending it to the target. This PR adds the support to use the client.Get() to transmit the RPC to target and to return the response to the fluent client.

@sthesayi sthesayi requested a review from robshakir October 8, 2021 20:11
Copy link
Copy Markdown
Member

@robshakir robshakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sthesayi sthesayi merged commit f3ec459 into openconfig:main Oct 8, 2021
@sthesayi sthesayi deleted the get_rpc branch October 8, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants