Conversation
Member
robshakir
commented
Jun 12, 2018
robshakir
commented
* (A) rpc/gnmi/protobuf-vals.md
- Add a document covering the use of protobuf binary values in
gNMI. This document provides a companion document covering
the protobuf_val field in TypedValue.
gcsl
approved these changes
Jun 12, 2018
aashaikh
reviewed
Jun 12, 2018
Contributor
aashaikh
left a comment
aashaikh
left a comment
There was a problem hiding this comment.
Couple of minor comments
rpc/gnmi/protobuf-vals.md
Outdated
| *Implementation Status*: Proposal | ||
|
|
||
| ## Problem Statement | ||
| For some applications the data carried by gNMI is directly described by a |
Contributor
There was a problem hiding this comment.
nit: add comma , "For some applications, the data ..."
rpc/gnmi/protobuf-vals.md
Outdated
| (the concatenated `path` and `prefix` fields) already indicates which message | ||
| is serialised within the Notification. | ||
|
|
||
| * Results in compatibilities when generated protobufs are within different |
rpc/gnmi/protobuf-vals.md
Outdated
| when generating an augmented version of a standard schema. In this case, the | ||
| augmented messages are backwards compatible with the standard messages, since | ||
| they are a strict superset of the fields, and hence can be deserialised into | ||
| the "standard" message. The differing type in protobuf.Any does not allow |
Contributor
There was a problem hiding this comment.
add backticks to protobuf.Any as above ?
rpc/gnmi/protobuf-vals.md
Outdated
| tree ID to a particular container or list element within the YANG schema as | ||
| defined by [RFC6020 Section | ||
| 6.5](https://tools.ietf.org/html/rfc6020#section-6.5). The schema path MUST | ||
| NOT be a path to a leaf element. * The `message-name` leaf MUST represent a |
Member
Author
There was a problem hiding this comment.
Fixed. vim wrapping issue!
aashaikh
approved these changes
Jun 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.