Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates libOpenCOR’s version and build/dependency configuration, and adjusts COMBINE archive handling to retain the original archive buffer for later use by libCOMBINE.
Changes:
- Bump
VERSION.txtto0.20260409.0. - Preserve COMBINE archive raw contents by threading the ZIP buffer through
CombineArchive/Impl. - Adjust Emscripten WASM memory/linker flags and update pinned libCellML package references/URLs.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| VERSION.txt | Version bump to 0.20260409.0. |
| src/support/combine/combinearchive.h | Extends private constructor to accept archive buffer. |
| src/support/combine/combinearchive.cpp | Moves archive contents into Impl to keep buffer alive; passes moved buffer from create(). |
| src/support/combine/combinearchive_p.h | Adds mArchiveContents storage on the pimpl. |
| src/CMakeLists.txt | Updates Emscripten linker flags (memory growth, initial/maximum memory, stack size) and refreshes documentation comment. |
| src/3rdparty/libCellML/CMakeLists.txt | Updates libCellML prebuilt SHA1s and source URL tag to 8cfa98e. |
| cmake/packages.cmake | Updates libCellML retrieval URL override to 8cfa98e. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Keep the raw archive buffer alive to ensure that the archive contents' lifetime extends beyond the initial libcombine::CombineArchive() initialisation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.