Add ARM support on Windows and Linux #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agarny
force-pushed
the
issue53
branch
14 times, most recently
from
94b38b8 to
e764123
Compare
The original idea was that developers could get binaries built automatically in their repo, which is convenient when testing things. However, we have `workflow_dispatch` so a developer could manually trigger it and thus avoid notifications when (automatic) CD fails for some reason or another.
Indeed, we need to build our C++ add-on, which makes things difficult (if not impossible?). Also, we would ideally distinguish between the Intel and ARM version (if possible), so too complicated and... not that useful in the end since we can package on each target OS.
And clean some other Web-related ones.
Start in 2025 since we never released anything in 2024.
This makes our bundle about 10% smaller.
Indeed, it cannot be enabled if `noEmit` is disabled, which it needs to be in our case. If `noEdit` was to be enabled then `tsconfig.json` would complain that `tsconfig.app.json` cannot disable emit.
agarny
force-pushed
the
issue53
branch
13 times, most recently
from
8e27c8a to
99a3141
Compare
Indeed, GHA doesn't currently have WoA runners.
Indeed, this requires using an ARM version of Electron and although we can get such a version, we can't run it on Windows on Intel, which means that our call to `electron-vite build` fails, sadly.
Looks more professional. We could indeed select our background image as well as text in Dialog-based and ConfirmDialog-based components!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53.