Keep the agent-bot tests from stalling CI runners#193
Merged
NagyVikt merged 1 commit intoApr 21, 2026
Conversation
The main-branch CI matrix stayed pinned in the Unit tests step across all three Node versions even after the review-workflow fixes landed. The strongest code-level suspect is the fake review bot daemon used by the agent lifecycle tests: it slept for 60 seconds per loop iteration, so if a runner only terminated the parent shell and not the whole process group, stopping the fake daemon could block for about a minute per test. This change replaces that body with a short, TERM-friendly loop shared through one helper so the same tests remain meaningful without depending on process-group semantics. Constraint: Preserve the existing agent lifecycle assertions while reducing runner-specific delay risk in detached-process cleanup Rejected: Leave the 60-second fake daemon as-is | matches the observed multi-minute CI stall too closely to ignore Rejected: Skip the agent lifecycle tests in CI | loses useful coverage instead of making the tests robust Confidence: medium Scope-risk: narrow Reversibility: clean Directive: Keep fake daemons in tests signal-friendly and short-cycle; do not reintroduce long blocking sleeps in lifecycle tests Tested: npm test; CI=1 GITHUB_ACTIONS=true node --test --test-name-pattern agents test/install.test.js; node --check bin/multiagent-safety.js Not-tested: Remote GitHub CI outcome after merging this test-only hang mitigation
NagyVikt
deleted the
agent/codex/fix-ci-review-bot-test-hang-2026-04-21-02-54
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated by scripts/agent-branch-finish.sh (PR flow).